-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add consensus bech32 prefix in app config #16945
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
aaronc and
testinginprod
and removed request for
a team
July 12, 2023 08:56
@julienrbrt your pull request is missing a changelog! |
API does not have a changelog. |
julienrbrt
changed the title
feat(api): add consensus bech32 prefix in auth config
feat(api): add consensus bech32 prefix in staking config
Jul 12, 2023
julienrbrt
changed the title
feat(api): add consensus bech32 prefix in staking config
feat(api): add consensus bech32 prefix in app config
Jul 12, 2023
19 tasks
alexanderbez
approved these changes
Jul 12, 2023
backporting this to get the proto changes in on the v0.50 branch (as they are published from buf there) |
@Mergifyio backport release/v0.50.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
(cherry picked from commit 74c351e) # Conflicts: # x/tx/signing/aminojson/internal/buf.lock
julienrbrt
added a commit
that referenced
this pull request
Jul 12, 2023
#16964) Co-authored-by: Julien Robert <julien@rbrt.fr>
This was referenced Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extract API changes from #16927 so I can tag and use that in the PR.
Additionally moves validator codec config in staking instead of auth.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change