Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add consensus bech32 prefix in app config #16945

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jul 12, 2023

Description

Extract API changes from #16927 so I can tag and use that in the PR.
Additionally moves validator codec config in staking instead of auth.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner July 12, 2023 08:56
@github-prbot github-prbot requested review from a team, aaronc and testinginprod and removed request for a team July 12, 2023 08:56
@github-actions
Copy link
Contributor

@julienrbrt your pull request is missing a changelog!

@julienrbrt
Copy link
Member Author

@julienrbrt your pull request is missing a changelog!

API does not have a changelog.

@julienrbrt julienrbrt changed the title feat(api): add consensus bech32 prefix in auth config feat(api): add consensus bech32 prefix in staking config Jul 12, 2023
@julienrbrt julienrbrt changed the title feat(api): add consensus bech32 prefix in staking config feat(api): add consensus bech32 prefix in app config Jul 12, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Jul 12, 2023
Merged via the queue into main with commit 74c351e Jul 12, 2023
@julienrbrt julienrbrt deleted the julien/bech32-prefix-auth branch July 12, 2023 17:39
@julienrbrt
Copy link
Member Author

julienrbrt commented Jul 12, 2023

backporting this to get the proto changes in on the v0.50 branch (as they are published from buf there)

@julienrbrt
Copy link
Member Author

@Mergifyio backport release/v0.50.x

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

backport release/v0.50.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 12, 2023
(cherry picked from commit 74c351e)

# Conflicts:
#	x/tx/signing/aminojson/internal/buf.lock
julienrbrt added a commit that referenced this pull request Jul 12, 2023
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants