Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(staking)!: add consensus and validator address codec in staking #16959

Merged
merged 12 commits into from
Jul 13, 2023
Merged

feat(staking)!: add consensus and validator address codec in staking #16959

merged 12 commits into from
Jul 13, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jul 12, 2023 •
edited
Loading

Description

Based on changes on #16945 for this commit: d490080

Moves address validator codec to staking, add consensus address codec to staking.

It will unblock: #16927

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt changed the title refactor(staking): add consensus and validator address codec in staking feat(staking): add consensus and validator address codec in staking Jul 12, 2023
@github-actions github-actions bot added the C:CLI label Jul 12, 2023
Base automatically changed from julien/bech32-prefix-auth to main July 12, 2023 17:39
@julienrbrt julienrbrt marked this pull request as ready for review July 12, 2023 21:52
@julienrbrt julienrbrt requested a review from a team as a code owner July 12, 2023 21:52
@github-actions

This comment has been minimized.

Sign in to view
@github-prbot github-prbot requested review from a team, kocubinski and likhita-809 and removed request for a team July 12, 2023 21:52
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 12, 2023
@julienrbrt julienrbrt changed the title feat(staking): add consensus and validator address codec in staking feat(staking)!: add consensus and validator address codec in staking Jul 12, 2023
This was referenced Jul 13, 2023
Closed
Closed
facundomedica
facundomedica approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one tiny nit

x/staking/keeper/keeper.go Outdated Show resolved Hide resolved
facundomedica and others added 2 commits July 13, 2023 10:13
@facundomedica
Merge branch 'main' into julien/bech32-staking
5dc6998
@julienrbrt @facundomedica
Update x/staking/keeper/keeper.go
2a8ad95 
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
@julienrbrt julienrbrt enabled auto-merge July 13, 2023 08:16
julienrbrt
julienrbrt commented Jul 13, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
tac0turtle
tac0turtle reviewed Jul 13, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@julienrbrt julienrbrt added this pull request to the merge queue Jul 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 13, 2023
@tac0turtle tac0turtle added this pull request to the merge queue Jul 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 13, 2023
@tac0turtle tac0turtle mentioned this pull request Jul 13, 2023
Merged
19 tasks
@julienrbrt
Copy link
Member Author

Seems like we are rate-limited by GH so we cannot merge yet.

@julienrbrt julienrbrt added this pull request to the merge queue Jul 13, 2023
Merged via the queue into main with commit e0be2b8 Jul 13, 2023
@julienrbrt julienrbrt deleted the julien/bech32-staking branch July 13, 2023 09:10
mergify bot pushed a commit that referenced this pull request Jul 13, 2023
@julienrbrt @mergify
feat(staking)!: add consensus and validator address codec in staking (#…
3b7b0aa 
…16959)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
(cherry picked from commit e0be2b8)

# Conflicts:
#	client/v2/go.mod
#	client/v2/go.sum
#	simapp/go.mod
#	simapp/go.sum
#	tests/go.mod
#	tests/go.sum
#	x/staking/keeper/keeper_test.go
@mergify mergify bot mentioned this pull request Jul 13, 2023
Merged
julienrbrt added a commit that referenced this pull request Jul 13, 2023
@mergify @julienrbrt
feat(staking)!: add consensus and validator address codec in staking …
4076c6a 
…(backport #16959) (#16977)

Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@facundomedica facundomedica facundomedica approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski kocubinski is a code owner

@likhita-809 likhita-809 Awaiting requested review from likhita-809

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/auth C:x/group C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julienrbrt @facundomedica @tac0turtle