Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: hide --output flags that don't work #17188

Merged
merged 3 commits into from
Jul 29, 2023
Merged

refactor: hide --output flags that don't work #17188

merged 3 commits into from
Jul 29, 2023

Conversation

zakir-code
Copy link
Contributor

Description

follow-up #17183

@zakir-code zakir-code requested a review from a team as a code owner July 29, 2023 13:16
@github-actions github-actions bot added C:CLI C:x/auth C:x/genutil genutil module issues labels Jul 29, 2023
@julienrbrt julienrbrt added backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Jul 29, 2023
julienrbrt
julienrbrt reviewed Jul 29, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly lgtm.

x/auth/client/cli/tx_multisign.go Outdated Show resolved Hide resolved
julienrbrt
julienrbrt approved these changes Jul 29, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK! Thanks!

@julienrbrt julienrbrt added this pull request to the merge queue Jul 29, 2023
Merged via the queue into cosmos:main with commit 0b5e7ed Jul 29, 2023
43 of 44 checks passed
mergify bot pushed a commit that referenced this pull request Jul 29, 2023
@zakir-code @mergify
refactor: hide --output flags that don't work (#17188)
74e771f 
Co-authored-by: Julien Robert <julien@rbrt.fr>
(cherry picked from commit 0b5e7ed)

# Conflicts:
#	x/auth/client/cli/tx_multisign.go
This was referenced Jul 29, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Jul 29, 2023
@zakir-code @mergify
refactor: hide --output flags that don't work (#17188)
63b1890 
Co-authored-by: Julien Robert <julien@rbrt.fr>
(cherry picked from commit 0b5e7ed)

# Conflicts:
#	x/auth/client/cli/tx_multisign.go
julienrbrt added a commit that referenced this pull request Jul 30, 2023
@mergify @zakir-code @julienrbrt
refactor: hide --output flags that don't work (backport #17188) (#1…
eba0b9e 
…7191)

Co-authored-by: zakir-code <80246097+zakir-code@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
julienrbrt added a commit that referenced this pull request Jul 30, 2023
@mergify @zakir-code @julienrbrt
refactor: hide --output flags that don't work (backport #17188) (#1…
1a2ad4f 
…7192)

Co-authored-by: zakir-code <80246097+zakir-code@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@PoisonPhang PoisonPhang mentioned this pull request Sep 12, 2023
Merged
@rootulp rootulp mentioned this pull request Jan 8, 2024
Closed
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@samricotta samricotta Awaiting requested review from samricotta

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/auth C:x/genutil genutil module issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zakir-code @julienrbrt