Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(x/auth): internal error on AccountInfo when PubKey is nil #17209

Merged
merged 2 commits into from
Jul 31, 2023
Merged

fix(x/auth): internal error on AccountInfo when PubKey is nil #17209

merged 2 commits into from
Jul 31, 2023

Conversation

facundomedica
Copy link
Member

Description

Closes: #17204

account.GetPubKey() explicitly states that it can return nil, so I don't think we should return an internal error on that case.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@facundomedica facundomedica added backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Jul 31, 2023
@facundomedica facundomedica requested a review from a team as a code owner July 31, 2023 09:13
@github-prbot github-prbot requested review from a team, alexanderbez and likhita-809 and removed request for a team July 31, 2023 09:13
@github-actions

This comment has been minimized.

Sign in to view
julienrbrt
julienrbrt approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK!

@facundomedica facundomedica added this pull request to the merge queue Jul 31, 2023
Merged via the queue into main with commit bf1803b Jul 31, 2023
@facundomedica facundomedica deleted the facu/fix-nilpubkey branch July 31, 2023 09:34
mergify bot pushed a commit that referenced this pull request Jul 31, 2023
@facundomedica @mergify
fix(x/auth): internal error on AccountInfo when PubKey is nil (#17209)
a38b2b2 
(cherry picked from commit bf1803b)
@mergify mergify bot mentioned this pull request Jul 31, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jul 31, 2023
@facundomedica @mergify
fix(x/auth): internal error on AccountInfo when PubKey is nil (#17209)
99bf713 
(cherry picked from commit bf1803b)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Jul 31, 2023
Merged
julienrbrt pushed a commit that referenced this pull request Jul 31, 2023
@mergify @facundomedica
fix(x/auth): internal error on AccountInfo when PubKey is nil (backport
ce496ea 
#17209) (#17210)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
julienrbrt added a commit that referenced this pull request Jul 31, 2023
@mergify @facundomedica @julienrbrt
fix(x/auth): internal error on AccountInfo when PubKey is nil (backport
404815c 
#17209) (#17211)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@PoisonPhang PoisonPhang mentioned this pull request Sep 12, 2023
Merged
@leonz789 leonz789 mentioned this pull request Apr 25, 2024
Merged
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@likhita-809 likhita-809 Awaiting requested review from likhita-809

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/auth
Projects
None yet
Milestone
No milestone
2 participants
@facundomedica @julienrbrt