Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): allow to properly register non app wiring modules (backport #17284) #17305

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 7, 2023

This is an automatic backport of pull request #17284 done by Mergify.
Cherry-pick of 60198f0 has failed:

On branch mergify/bp/release/v0.47.x/pr-17284
Your branch is up to date with 'origin/release/v0.47.x'.

You are currently cherry-picking commit 60198f077.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   docs/docs/building-apps/01-app-go-v2.md

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   CHANGELOG.md
	both modified:   runtime/app.go
	both modified:   runtime/module.go
	deleted by us:   scripts/init-simapp.sh

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit 60198f0)

# Conflicts:
#	CHANGELOG.md
#	runtime/app.go
#	runtime/module.go
#	scripts/init-simapp.sh
@mergify mergify bot requested a review from a team as a code owner August 7, 2023 11:11
@mergify mergify bot added the conflicts label Aug 7, 2023
@julienrbrt julienrbrt self-assigned this Aug 7, 2023
@julienrbrt julienrbrt removed their assignment Aug 7, 2023
@julienrbrt julienrbrt enabled auto-merge (squash) August 7, 2023 11:21
@julienrbrt julienrbrt merged commit 56f5b59 into release/v0.47.x Aug 7, 2023
23 of 26 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v0.47.x/pr-17284 branch August 7, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant