Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nil pointer ref priority nonce mempool iterator #17668

Merged
merged 3 commits into from
Sep 11, 2023
Merged

fix: nil pointer ref priority nonce mempool iterator #17668

merged 3 commits into from
Sep 11, 2023

Conversation

0xmuralik
Copy link
Contributor

Description

Closes: #17392

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@0xmuralik 0xmuralik requested a review from a team as a code owner September 10, 2023 09:25
@0xmuralik 0xmuralik changed the title Murali/priority nonce mempool fix: priority nonce mempool iterator Sep 10, 2023
@0xmuralik 0xmuralik changed the title fix: priority nonce mempool iterator fix: nil pointer ref priority nonce mempool iterator Sep 10, 2023
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Sep 10, 2023
@julienrbrt
Copy link
Member

Can we get a changelog under unreleased bug fix.

@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Sep 11, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Sep 11, 2023
Merged via the queue into cosmos:main with commit cc7b117 Sep 11, 2023
45 of 46 checks passed
mergify bot pushed a commit that referenced this pull request Sep 11, 2023
@0xmuralik @mergify
fix: nil pointer ref priority nonce mempool iterator (#17668)
2c96b60 
(cherry picked from commit cc7b117)
@mergify mergify bot mentioned this pull request Sep 11, 2023
Merged
mergify bot pushed a commit that referenced this pull request Sep 11, 2023
@0xmuralik @mergify
fix: nil pointer ref priority nonce mempool iterator (#17668)
d62c8e0 
(cherry picked from commit cc7b117)

# Conflicts:
#	types/mempool/priority_nonce.go
@mergify mergify bot mentioned this pull request Sep 11, 2023
Merged
tac0turtle pushed a commit that referenced this pull request Sep 11, 2023
@mergify @0xmuralik @julienrbrt
fix: nil pointer ref priority nonce mempool iterator (backport #17668) (
612d0a6 
#17674)

Co-authored-by: Bala Murali Krishna Komatireddy <krishna192reddy@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
tac0turtle pushed a commit that referenced this pull request Sep 11, 2023
@mergify @0xmuralik @julienrbrt
fix: nil pointer ref priority nonce mempool iterator (backport #17668) (
55aa507 
#17675)

Co-authored-by: Bala Murali Krishna Komatireddy <krishna192reddy@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Mar 20, 2024
Open
12 tasks
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@samricotta samricotta Awaiting requested review from samricotta

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Priority Nonce Mempool Nil Pointer Dereference (Next)
3 participants
@0xmuralik @julienrbrt @alexanderbez