-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.23.0 #1769
Release v0.23.0 #1769
Conversation
This subverts the really hard to decipher ABCI error message, with a nice user friendly error message.
Codecov Report
@@ Coverage Diff @@
## master #1769 +/- ##
==========================================
- Coverage 60.64% 60.63% -0.01%
==========================================
Files 119 119
Lines 6906 6917 +11
==========================================
+ Hits 4188 4194 +6
- Misses 2479 2484 +5
Partials 239 239 |
When will this be ready for review/release? |
Waiting on a decision from governance on the testnet (whether or not to stop gaia-7001, dump state, and start gaia-7002), and the genesis block for gaia-7002. |
Looks like this release will also need to include the fix for the bug that stopped |
Also @zmanian mentioned wanting to change proposal period and maybe other governance parameters. |
I propose we use the release checklist here #1803 for the first time here. |
Since some parameters, such as liveness slashing, aren't defined in the genesis.json file, it would be great if we can make them default values within the code so that all our future testnets can be released with them. Below is a list of proposed parameters for
|
I think the jail time is too short. The revoked validator doesn't realize the jail time before he can unrevoke. How about some other parameters like begin/complete mature time for unbond and redelegation? Others are good! |
Please add more steaks to the validators more up-line, like me for example, and to others good validators for not stay in 65% 66% 67% 66%, |
I like the proposed values. I think @zmanian proposed purging validators that did not delegate any steak in gaia-7001 from genesis. I would be happy with this, or perhaps being a bit less aggressive and only purge the validators who never came online at all. With a cap of 128 validators for gaia-7002, this would leave plenty of room for non-genesis validators. |
@adrianbrink Do you have definitions for each of the parameters, especially the two types of slashing? Based on my inferred definitions, the parameters feel like a beneficial starting point. Additional comments/questions -
("Pager" duty brings back bad memories of actually carrying a pager and laptop w/dial-up connection :) )
|
@mattharrop I think that is the current plan. |
Those settings look good. @kwunyeung +1 for adding unbond & redelegate mature times. For the 10% liveness slashing, can someone please confirm my understanding that once a validator triggers the 20000/40000, the slashing (10%) happens once as they unbond, and then when they unrevoke, the counter will be reset for a fresh 40000 blocks. I haven't had a chance to go through the code and check. Edit: I was right. Answer discussed here: |
@KamuelBob the 10% slashing happens when you missed 20000/40000 blocks. At the same time, your shares are unbonded and your validator will be revoked. After waiting for the jail time, you can unrevoke your validator. Your remaining shares will be bonded back. |
Maybe tomorrow afternoon PDT we can test this quickly internally by hand with reasonable (temporary-internal) parameters before we officially launch the testnet... unless there's an argument not to do so. |
eb032a4
to
2bbd721
Compare
* Update to tendermint v0.22.6 - This was cherry-picked and fixed from develop - Updates all crypto imports for changes from v0.22.5
slashing for downtime is 10%
* Avoid slashing & revoking no longer stored or already revoked validators for downtime * Add testcase * Update PENDING.md
* add revoked to human-readable validator * changelog * added failing test * add intra-tx counter to the genesis validators * changelog
* fixed proposaltype string bug
docs/
)CHANGELOG.md
cmd/gaia
andexamples/
For Admin Use: