feat(x/gov): better gov genesis validation

[julienrbrt]

Description

A-15

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

[coderabbitai]

Warning

Rate Limit Exceeded

@julienrbrt has exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 2 minutes and 31 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 8de4177 and 8d8baf2.

Walkthrough

The Cosmos SDK has undergone updates to enhance error handling and validation across several modules. The x/gov module now includes more detailed genesis validation, ensuring proposal IDs, deposits, and votes are correct. The x/bank, x/distribution, and x/slashing modules have been improved to return errors in situations where they previously would panic, increasing the robustness and reliability of the system.

Changes

File(s)	Change Summary
x/gov/types/v1/genesis.go	Added import for "fmt", updated ValidateGenesis function comment, and included validation logic for proposal IDs, deposits, and votes.
x/gov/types/v1/.../genesis_test.go	Expanded TestValidateGenesis with test cases for duplicate proposals, votes, deposits, and handling of non-existent proposal IDs.
CHANGELOG.md	Documented improvements in error handling and validation for x/gov, x/bank, x/distribution, and x/slashing modules.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• You can reply to a review comment from CodeRabbit.
• You can also chat with CodeRabbit bot directly around the specific lines of code or files in the PR by tagging @coderabbitai in a new comment.
• You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[julienrbrt]

Adding the changelog here, even though it should be in x/gox/changelog.md, as we backport this, we'll remove the line anyway at next point version.

[alexanderbez]

LGTM!

[odeke-em]

Thank you @julienrbrt, LGTM! A recommendation for more rigor given that we've expanded the checks would be that for much stronger tests, instead of a boolean, please use an expected error sub string to assert against specific errors instead of just a generic error.

[julienrbrt]

Thank you @julienrbrt, LGTM! A recommendation for more rigor given that we've expanded the checks would be that for much stronger tests, instead of a boolean, please use an expected error sub string to assert against specific errors instead of just a generic error.

Right, I just followed how the test was and checked coverage (got lazy, lol). But we can definitely improve it at the same time, will do.

[odeke-em]

LGTM++ and thank you @julienrbrt