feat(x/accounts): Add schema caching feature and corresponding test case #20055
Conversation
Signed-off-by: Hwangjae Lee <meetrick@gmail.com>
WalkthroughThe recent updates primarily focus on enhancing the efficiency and functionality of GitHub Actions workflows and improving various modules within the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
This commit modifies the queryServer struct methods to avoid copying the entire struct by adding a mutex lock. Instead of changing the receiver to a pointer, a mutex named 'mu' is introduced to synchronize access to the struct's fields. This approach minimizes the impact on other functions while ensuring safe concurrent access to the methods. Signed-off-by: Hwangjae Lee <meetrick@gmail.com>
Signed-off-by: Hwangjae Lee <meetrick@gmail.com>
|
@tac0turtle Hi, Could you add another reviewer as an assignee? It seems like @testinginprod hasn't been able to review since last week. |
x/accounts/query_server.go
Outdated
| return schema, nil | ||
| } | ||
|
|
||
| // If not cached, generate and cache the schema |
There was a problem hiding this comment.
I have not much context of it, but seems like it is not a good solution, why not initialize schemas in the constructor NewQueryServer?
There was a problem hiding this comment.
@cool-develope Thanks for the review. I wanted to make as few changes to the code as possible, but ended up with some ambiguous code. Following your advice to improve the code, there were many modifications. Could you review it again?
There was a problem hiding this comment.
hmm, I think we need more research of it, leave the decision to @testinginprod
There was a problem hiding this comment.
Thanks for your opinion!
- Updated all methods of the queryServer struct to use pointer receivers, ensuring compliance with the v1.QueryServer interface. - Refactored the NewQueryServer function to precalculate and store schemas for efficient schema retrieval. - Initialized the schemaCache with a precomputed length based on the length of precalculated schemas, ensuring efficient memory usage. - Added a schemas field to the queryServer struct to store precalculated schemas. - Updated the AccountQuery and Schema methods to use pointer receivers. - Added comments to describe the purpose of the Schema method. - Ensured the AccountType and AccountNumber methods use pointer receivers. Signed-off-by: Hwangjae Lee <meetrick@gmail.com>
|
Would it be possible not to use a mutex? I don't think this is something we'd like to have here |
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…osmos#20115) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: guoguangwu <guoguangwug@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Marko <marko@baricevic.me>
…smos#20165) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
….5.0 (cosmos#20164) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: cuithon <dscs@outlook.com>
github-actions
bot
removed
C:x/group
C:x/nft
C:orm
Type: Build
Type: ADR
Type: CI
C:x/consensus
C:collections
C:Confix
Signed-off-by: Hwangjae Lee <meetrick@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@julienrbrt I removed it, Thanks |
x/accounts/query_server.go
Outdated
| schemas := v1.MakeAccountsSchemas(k.accounts) | ||
| return &queryServer{ | ||
| k: k, | ||
| schemaCache: make(map[string]*v1.SchemaResponse, len(schemas)), // Initialize with precomputed length |
There was a problem hiding this comment.
SchemaCache field is not needed anymore
There was a problem hiding this comment.
Thanks, It is removed
Signed-off-by: Hwangjae Lee <meetrick@gmail.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- x/accounts/query_server.go (3 hunks)
Additional Context Used
Path-based Instructions (1)
x/accounts/query_server.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (5)
x/accounts/query_server.go (5)
13-21: TheNewQueryServerfunction correctly initializes theschemasfield. Ensure no references toschemaCacheremain.
Line range hint
30-55: TheAccountQuerymethod handles errors and responses correctly. No issues found.
59-67: TheSchemamethod correctly retrieves the schema from the precalculated schemas and handles errors appropriately. No issues found.
Line range hint
71-81: TheAccountTypemethod handles errors and responses correctly. No issues found.
Line range hint
85-93: TheAccountNumbermethod handles errors and responses correctly. No issues found.
Signed-off-by: Hwangjae Lee <meetrick@gmail.com>
|
@sontrinh16 Could you add this PR to the merge queue? |
* main: (95 commits) fix(x/accounts): check for overflows in multisig weights and votes (#20384) docs(x/account/auth): Improve error handling and comments in fee.go (#20426) docs: fix some markdown syntax (#20432) revert: bank change module to account change (#20427) fix: nil pointer panic when store don't exists in historical version (#20425) fix(store/v2): Remove should not error on miss (#20423) chore: upstream more changes from v2 (#20387) docs(x/auth/ante): fixed typo in TxWithTimeoutHeight interface name (#20418) fix: avoid default sendenabled for module accounts (#20419) docs(x/auth): fixed typo in command example for multisign transaction (#20417) build(deps): Bump bufbuild/buf-setup-action from 1.31.0 to 1.32.0 (#20413) build(deps): Bump github.com/hashicorp/go-plugin from 1.6.0 to 1.6.1 in /store (#20414) feat(x/accounts): Add schema caching feature and corresponding test case (#20055) refactor(runtime/v2): remove dependency on sdk (#20389) refactor!: turn MsgsV2 into ReflectMessages to make it less confusing (#19839) docs: Enhanced the ParsePagination method documentation (#20385) refactor(runtime,core): split router service (#20401) chore: fix spelling errors (#20400) docs: Documented error handling in OfferSnapshot method (#20380) build(deps): Bump google.golang.org/grpc from 1.63.2 to 1.64.0 (#20390) ...
Description
Add schema caching feature and corresponding test case
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
New Features
Updates
amannn/action-semantic-pull-requestto versionv5.5.2.bufbuild/buf-setup-actionto versionv1.31.0.test-x-accounts-lockupfor specific file testing in the workflow.Bug Fixes
Documentation
CHANGELOG.mdandUPGRADING.mdwith new changes and deprecations.Chores
Makefilebuild process.