fix(x/consensus): fix .proto file placement #20646
Conversation
WalkthroughThe script Changes
Sequence Diagram(s)The changes do not significantly alter the control flow or introduce new features requiring sequence diagrams. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
@kocubinski your pull request is missing a changelog! |
|
Right now check |
|
Ok, combing the logs for env vars I was able to reproduce: seems it may be a logic error in |
| @@ -1,6 +1,6 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| set -e -o pipefail | |||
| set -e | |||
There was a problem hiding this comment.
I am removing pipefail because none of the pipe logic seems to require that a non-terminal expression should produce a global error; the existing case (ln 45) was a false negative.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (2)
scripts/go-lint-all.bash (2)
Line range hint
48-48: Double quote array expansions to avoid re-splitting elements.- for dir in ${GIT_DIFF[@]}; do + for dir in "${GIT_DIFF[@]}"; doThis change ensures that each element in the array is treated as a single word, which is crucial when directory names contain spaces.
Line range hint
48-48: Refactor the handling ofGIT_DIFFfor clarity and robustness.- GIT_DIFF=$(echo $GIT_DIFF | tr -d "'" | tr ' ' '\n' | grep '\.go$' | grep -v '\.pb\.go$' | grep -Eo '^[^/]+\/[^/]+' | uniq) + GIT_DIFF=$(echo "$GIT_DIFF" | tr -d "'" | tr ' ' '\n' | grep -E '\.go$' | grep -vE '\.pb\.go$' | grep -Eo '^[^/]+\/[^/]+' | sort -u)This version ensures proper quoting and uses
sort -uinstead ofuniqfor better reliability in sorting and deduplication.
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (1)
x/consensus/types/consensus.pb.gois excluded by!**/*.pb.go
Files selected for processing (1)
- scripts/go-lint-all.bash (1 hunks)
Additional context used
Shellcheck
scripts/go-lint-all.bash
[error] 48-48: Double quote array expansions to avoid re-splitting elements. (SC2068)
| @@ -1,6 +1,6 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| set -e -o pipefail | |||
| set -e | |||
There was a problem hiding this comment.
The change from set -e -o pipefail to set -e affects error handling in pipelines.
This modification might cause the script to not exit on errors in a pipeline, which could lead to silent failures. Consider restoring set -o pipefail if the script relies on the correct status codes from piped commands.
* main: fix(x/staking): stop validators from rotating to the same key on the same block (#20649) perf: add cache to address codec (#20122) build(deps): Bump google.golang.org/protobuf from 1.34.1 to 1.34.2 (#20632) fix: remove recipient amount from map (#20625) fix(proto): remove conditional preventing proper generated file placement (#20650) (serverv2/cometbft) Read config from commands & handle `FlagNode` (#20621) fix(x/consensus): fix .proto file placement (#20646) fix(store): avoid nil error on not exhausted payload stream (#20644) fix (x/accounts): Fix genesis condition check (#20645) feat(accounts): add genesis account initialization (#20642) fix(x/gov): limit execution in gov (#20348)
Description
Recently I've noticed a difference in output of running
make protogenandscripts/protocgen.sh, and will be opening a few PRs correcting that.This PR places all
x/consensusproto files in the proper location, which we decided was the within the module and not the top-levelproto/folder.Before this patch,
make proto-genleaves behind some files in a top-levelcosmossdk.iofolder (note these files are supposed to get moved byscripts/protocgen.sh):After:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit