Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(x/consensus): fix .proto file placement #20646

Merged
merged 4 commits into from
Jun 12, 2024
Merged

fix(x/consensus): fix .proto file placement #20646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1fa9e4
fix(x/consensus): fix .proto file placement
kocubinski Jun 12, 2024
63daf2b
remove pipefail
kocubinski Jun 12, 2024
76832ae
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocu/proto-c…
kocubinski Jun 12, 2024
7446aea
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocu/proto-c…
kocubinski Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/go-lint-all.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

set -e -o pipefail
set -e
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am removing pipefail because none of the pipe logic seems to require that a non-terminal expression should produce a global error; the existing case (ln 45) was a false negative.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from set -e -o pipefail to set -e affects error handling in pipelines.

This modification might cause the script to not exit on errors in a pipeline, which could lead to silent failures. Consider restoring set -o pipefail if the script relies on the correct status codes from piped commands.


REPO_ROOT="$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )/.." &> /dev/null && pwd )"
export REPO_ROOT
Expand Down
0 proto/cosmos/consensus/v1/consensus.proto → ...proto/cosmos/consensus/v1/consensus.proto
View file
Open in desktop
File renamed without changes.
46 changes: 23 additions & 23 deletions x/consensus/types/consensus.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading