fix: avoid build fail when make localnet-build-env #20671
Conversation
WalkthroughWalkthroughThe changes migrate the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (3)
contrib/images/simd-env/Dockerfile (3)
Line range hint
3-3: Pin versions in apk add to ensure reproducibility.- RUN apk add build-base git linux-headers + RUN apk add build-base=latest git=latest linux-headers=latestAlso, consider using the
--no-cacheoption to avoid unnecessary cache storage:- RUN apk add build-base git linux-headers + RUN apk add --no-cache build-base git linux-headers
Line range hint
38-38: Always tag the version of an image explicitly to ensure consistency.- FROM alpine AS run + FROM alpine:latest AS run
Line range hint
39-39: Pin versions in apk add to ensure reproducibility.- RUN apk add bash curl jq + RUN apk add bash=latest curl=latest jq=latestAlso, consider using the
--no-cacheoption to avoid unnecessary cache storage:- RUN apk add bash curl jq + RUN apk add --no-cache bash curl jq
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- contrib/images/simd-env/Dockerfile (1 hunks)
Additional context used
Hadolint
contrib/images/simd-env/Dockerfile
[warning] 3-3: Pin versions in apk add. Instead of
apk add <package>useapk add <package>=<version>(DL3018)
[info] 3-3: Use the
--no-cacheswitch to avoid the need to use--updateand remove/var/cache/apk/*when done installing packages (DL3019)
[warning] 38-38: Always tag the version of an image explicitly (DL3006)
[warning] 39-39: Pin versions in apk add. Instead of
apk add <package>useapk add <package>=<version>(DL3018)
[info] 39-39: Use the
--no-cacheswitch to avoid the need to use--updateand remove/var/cache/apk/*when done installing packages (DL3019)
Additional comments not posted (1)
contrib/images/simd-env/Dockerfile (1)
30-30: Ensure the new module path in COPY command is correct and accessible.Verification successful
The directory "core/testing" exists, and both "go.mod" and "go.sum" files are present within it. The COPY command in the Dockerfile should work correctly.
- contrib/images/simd-env/Dockerfile, line 30
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the new module path is accessible. # Test: Check if the module path exists. if [ -d "core/testing" ]; then echo "Directory exists." else echo "Directory does not exist." fiLength of output: 70
Script:
#!/bin/bash # Description: Verify the existence of go.mod and go.sum in the core/testing directory. # Test: Check if the files exist. if [ -f "core/testing/go.mod" ] && [ -f "core/testing/go.sum" ]; then echo "Both files exist." else if [ ! -f "core/testing/go.mod" ]; then echo "go.mod does not exist." fi if [ ! -f "core/testing/go.sum" ]; then echo "go.sum does not exist." fi fiLength of output: 110
* main: feat(tx): port simappv2 changes (#20648) build(deps): Bump github.com/spf13/cobra from 1.8.0 to 1.8.1 (#20682) chore(proto): fix comments (#20679) (serverv2/cometbft) Commands support both json and yaml output (#20670) fix(x/staking,x/auth): regenerate mock to fix test (#20684) docs: ADR 074: Msg v2 (#20618) fix: nested multisig signatures using CLI (#20438) chore: fix spelling errors (#20674) fix: align Dockerfile for build-push-action (#20672) fix: avoid build fail when make localnet-build-env (#20671) build(deps): Bump bufbuild/buf-setup-action from 1.32.2 to 1.33.0 (#20669) chore: make function comment match function names (#20666) chore(consensus): add cometInfo to consensus (#20615) chore: fix typos (#20662) fix: Properly parse json in the wait-tx command. (#20631) fix(sims): check before sending RotateConsPubKey (#20659) test(types/address): add unit tests for the file types/address.go (#20237)
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit