fix: nested multisig signatures using CLI #20438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe recent updates primarily address the handling and signing of nested multisig accounts in the Cosmos SDK. Key improvements include adding functions for marshaling and unmarshaling Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
This comment has been minimized.
This comment has been minimized.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (4)
- crypto/keys/multisig/multisig.go (1 hunks)
- x/auth/client/cli/tx_multisign.go (3 hunks)
- x/auth/client/cli/tx_sign.go (5 hunks)
- x/auth/client/tx.go (1 hunks)
Additional Context Used
Path-based Instructions (4)
crypto/keys/multisig/multisig.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/auth/client/tx.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/auth/client/cli/tx_multisign.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/auth/client/cli/tx_sign.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (5)
crypto/keys/multisig/multisig.go (1)
151-154: Ensure that theMarshalmethod is defined and accessible within the context whereMarshalAminois used.x/auth/client/cli/tx_multisign.go (2)
60-60: The addition of theflagSkipSignatureVerificationflag is appropriate for enabling users to skip signature verification when necessary.
Line range hint
113-167: The modifications to handle the skipping of signature verification based on theflagSkipSignatureVerificationare implemented correctly.x/auth/client/cli/tx_sign.go (2)
278-304: The implementation ofisMultisigSignerfunction is correct and effectively handles the checking of signers in nested multisig structures.
229-262: The modifications to support multisig signing, including error handling and signature verification, are implemented correctly.
crypto/keys/multisig/multisig.go
Outdated
Comment on lines
156
to
159
| // UnmarshalAmino overrides amino binary marshaling. | ||
| func (m *LegacyAminoPubKey) UnmarshalAmino(bz []byte) error { | ||
| return m.Unmarshal(bz) | ||
| } |
There was a problem hiding this comment.
Tip
Codebase Verification
The Unmarshal method is not defined in the LegacyAminoPubKey struct, nor does it embed any other structs or interfaces that provide this method. This will cause the UnmarshalAmino method to fail at runtime.
LegacyAminoPubKeystruct definition:crypto/keys/multisig/keys.pb.go:31api/cosmos/crypto/multisig/keys.pulsar.go:576
Please ensure that the Unmarshal method is implemented for the LegacyAminoPubKey struct.
Analysis chain
Ensure that the Unmarshal method is defined and accessible within the context where UnmarshalAmino is used.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the existence of the `Unmarshal` method used in `UnmarshalAmino`.
# Test: Search for the `Unmarshal` method definition. Expect: At least one definition.
ast-grep --lang go --pattern $'func (m *LegacyAminoPubKey) Unmarshal(bz []byte) error { $$$ }'
Length of output: 95
Script:
#!/bin/bash
# Description: Verify the existence of the `Unmarshal` method used in `UnmarshalAmino`.
# Test 1: Search for any `Unmarshal` method definitions in the entire codebase.
ast-grep --lang go --pattern $'func ($_ $_) Unmarshal(bz []byte) error { $$$ }'
# Test 2: Inspect the `LegacyAminoPubKey` struct for any embedded structs or implemented interfaces.
ast-grep --lang go --pattern $'type LegacyAminoPubKey struct { $$$ }'
Length of output: 1733
julienrbrt
reviewed
Jun 3, 2024
| @@ -109,6 +110,10 @@ func makeMultiSignCmd() func(cmd *cobra.Command, args []string) (err error) { | |||
| return err | |||
| } | |||
|
|
|||
| // avoid signature verification if the sender of the tx is different than | |||
| // the multisig key (useful for nested multisigs). | |||
| skipSigVerify, _ := cmd.Flags().GetBool(flagSkipSignatureVerification) | |||
There was a problem hiding this comment.
We should describe this flag somewhere in the docs.
facundomedica
commented
Jun 10, 2024
crypto/keys/multisig/multisig.go
Outdated
| @@ -169,6 +169,9 @@ func packPubKeys(pubKeys []cryptotypes.PubKey) ([]*types.Any, error) { | |||
| return nil, err | |||
| } | |||
| anyPubKeys[i] = any | |||
|
|
|||
| // sets the compat.aminoBz value | |||
| anyPubKeys[i].UnmarshalAmino(pubKeys[i].Bytes()) | |||
There was a problem hiding this comment.
This was the necessary fix to allow nested anys
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (2)
- client/keys/output_test.go (1 hunks)
- crypto/keys/multisig/multisig.go (1 hunks)
Additional context used
Path-based instructions (2)
client/keys/output_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"crypto/keys/multisig/multisig.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
golangci-lint
crypto/keys/multisig/multisig.go
174-174: Error return value of
(*github.com/cosmos/gogoproto/types/any.Any).UnmarshalAminois not checked (errcheck)
GitHub Check: golangci-lint
crypto/keys/multisig/multisig.go
[failure] 174-174:
Error return value of(*github.com/cosmos/gogoproto/types/any.Any).UnmarshalAminois not checked (errcheck)
Comment on lines
+48
to
+70
| // TestBech32KeysOutputNestedMsig tests that the output of a nested multisig key is correct | ||
| func TestBech32KeysOutputNestedMsig(t *testing.T) { | ||
| sk := secp256k1.PrivKey{Key: []byte{154, 49, 3, 117, 55, 232, 249, 20, 205, 216, 102, 7, 136, 72, 177, 2, 131, 202, 234, 81, 31, 208, 46, 244, 179, 192, 167, 163, 142, 117, 246, 13}} | ||
| tmpKey := sk.PubKey() | ||
| nestedMultiSig := kmultisig.NewLegacyAminoPubKey(1, []types.PubKey{tmpKey}) | ||
| multisigPk := kmultisig.NewLegacyAminoPubKey(2, []types.PubKey{tmpKey, nestedMultiSig}) | ||
| k, err := keyring.NewMultiRecord("multisig", multisigPk) | ||
| require.NotNil(t, k) | ||
| require.NoError(t, err) | ||
|
|
||
| pubKey, err := k.GetPubKey() | ||
| require.NoError(t, err) | ||
|
|
||
| accAddr := sdk.AccAddress(pubKey.Address()) | ||
| expectedOutput, err := NewKeyOutput(k.Name, k.GetType(), accAddr, multisigPk, addresscodec.NewBech32Codec("cosmos")) | ||
| require.NoError(t, err) | ||
|
|
||
| out, err := MkAccKeyOutput(k, addresscodec.NewBech32Codec("cosmos")) | ||
| require.NoError(t, err) | ||
|
|
||
| require.Equal(t, expectedOutput, out) | ||
| require.Equal(t, "{Name:multisig Type:multi Address:cosmos1nffp6v2j7wva4y4975exlrv8x5vh39axxt3swz PubKey:{\"@type\":\"/cosmos.crypto.multisig.LegacyAminoPubKey\",\"threshold\":2,\"public_keys\":[{\"@type\":\"/cosmos.crypto.secp256k1.PubKey\",\"key\":\"AurroA7jvfPd1AadmmOvWM2rJSwipXfRf8yD6pLbA2DJ\"},{\"@type\":\"/cosmos.crypto.multisig.LegacyAminoPubKey\",\"threshold\":1,\"public_keys\":[{\"@type\":\"/cosmos.crypto.secp256k1.PubKey\",\"key\":\"AurroA7jvfPd1AadmmOvWM2rJSwipXfRf8yD6pLbA2DJ\"}]}]} Mnemonic:}", fmt.Sprintf("%+v", out)) | ||
| } |
There was a problem hiding this comment.
The test TestBech32KeysOutputNestedMsig appears comprehensive and correctly tests the output of a nested multisig key. However, consider adding more assertions to verify the structure of the nested multisig key in more detail, such as checking individual public keys within the nested structure.
crypto/keys/multisig/multisig.go
Outdated
| @@ -169,6 +169,9 @@ | |||
| return nil, err | |||
| } | |||
| anyPubKeys[i] = any | |||
|
|
|||
| // sets the compat.aminoBz value | |||
| anyPubKeys[i].UnmarshalAmino(pubKeys[i].Bytes()) | |||
There was a problem hiding this comment.
The error return value of UnmarshalAmino is not checked. It's important to handle potential errors to avoid runtime panics or unexpected behavior.
- anyPubKeys[i].UnmarshalAmino(pubKeys[i].Bytes())
+ if err := anyPubKeys[i].UnmarshalAmino(pubKeys[i].Bytes()); err != nil {
+ return nil, err
+ }Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| anyPubKeys[i].UnmarshalAmino(pubKeys[i].Bytes()) | |
| if err := anyPubKeys[i].UnmarshalAmino(pubKeys[i].Bytes()); err != nil { | |
| return nil, err | |
| } |
Tools
golangci-lint
174-174: Error return value of
(*github.com/cosmos/gogoproto/types/any.Any).UnmarshalAminois not checked (errcheck)
GitHub Check: golangci-lint
[failure] 174-174:
Error return value of(*github.com/cosmos/gogoproto/types/any.Any).UnmarshalAminois not checked (errcheck)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…/fix-nested-ms-main
tac0turtle
reviewed
Jun 11, 2024
| @@ -57,6 +57,7 @@ The SIGN_MODE_DIRECT sign mode is not supported.' | |||
| Args: cobra.MinimumNArgs(3), | |||
| } | |||
|
|
|||
| cmd.Flags().Bool(flagSkipSignatureVerification, false, "Skip signature verification") | |||
There was a problem hiding this comment.
can we add this to some docs somewhere? easy to get lost in the immense amount of code
There was a problem hiding this comment.
Added docs and changelog 💪
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (2)
- x/auth/README.md (1 hunks)
- x/tx/CHANGELOG.md (1 hunks)
Additional context used
Path-based instructions (2)
x/tx/CHANGELOG.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"x/auth/README.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
LanguageTool
x/tx/CHANGELOG.md
[grammar] ~157-~157: When ‘32-bit’ is used as a modifier, it is usually spelled with a hyphen. (BIT_HYPHEN)
Context: ...mos-sdk/pull/15849) Fix int64 usage for 32 bit platforms. ## v0.5.1 ### Features * ...x/auth/README.md
[uncategorized] ~40-~40: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...s to perform actions on behalf of other accounts and enables a granter to grant authoriz...
[style] ~92-~92: Consider a shorter alternative to avoid wordiness. (IN_ORDER_TO_PREMIUM)
Context: ...nt struct conforming to the interface - in order to write the account to the store, the acc...
[style] ~148-~148: The phrase ‘have the ability to’ might be wordy. Consider using “can”. (HAS_THE_ABILITY_TO)
Context: ...verTx`, as CometBFT proposers presently have the ability to include in their proposed block transac...
[uncategorized] ~154-~154: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...lowing order: *SetUpContextDecorator: Sets theGasMeterin theContextan...
[uncategorized] ~156-~156: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...ed. *RejectExtensionOptionsDecorator: Rejects all extension options which can...
[uncategorized] ~158-~158: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...f transactions. *MempoolFeeDecorator: Checks if thetxfee is above local m...
[uncategorized] ~160-~160: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...gCheckTx. *ValidateBasicDecorator: Callstx.ValidateBasicand returns an...
[uncategorized] ~162-~162: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...nil error. *TxTimeoutHeightDecorator: Check for atxheight timeout. * `Va...
[uncategorized] ~164-~164: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...ight timeout. *ValidateMemoDecorator: Validatestxmemo with application pa...
[uncategorized] ~166-~166: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...il error. *ConsumeGasTxSizeDecorator: Consumes gas proportional to thetxs...
[uncategorized] ~168-~168: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...tion parameters. *DeductFeeDecorator: Deducts theFeeAmountfrom first sign...
[uncategorized] ~170-~170: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...granter account. *SetPubKeyDecorator: Sets the pubkey from atx's signers t...
[uncategorized] ~172-~172: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ... context. *ValidateSigCountDecorator: Validates the number of signatures in `...
[uncategorized] ~174-~174: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...-parameters. *SigGasConsumeDecorator: Consumes parameter-defined amount of ga...
[uncategorized] ~176-~176: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...ecorator. *SigVerificationDecorator`: Verifies all signatures are valid. This...
[uncategorized] ~178-~178: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...orator. *IncrementSequenceDecorator`: Increments the account sequence for eac...
[style] ~186-~186: Although a hyphen is possible, it is not necessary in a compound modifier in which the first word is an adverb that ends in ‘ly’. (HYPHENATED_LY_ADVERB_ADJECTIVE)
Context: ... ### Account Keeper Presently only one fully-permissioned account keeper is exposed, which has th...
[uncategorized] ~252-~252: Did you mean “its” (the possessive pronoun)? (ITS_PREMIUM)
Context: ... allow users to query for an account by it's address. ```bash simd query auth accou...
[style] ~403-~403: Consider using a more formal alternative. (MORE_INFO)
Context: ... Use directly the--helpflag to get more information about thetxcommand. ```bash simd t...
[uncategorized] ~436-~436: Possible missing preposition found. (AI_HYDRA_LEO_MISSING_OF)
Context: ...igned.json ``` The result is multiples signed transactions. For combining the signed ...
[grammar] ~436-~436: Please verify that the plural noun “transactions” is in agreement with the quantifier “one”. Did you mean to use the singular form? (ONE_PLURAL)
Context: ... combining the signed transactions into one transactions, use the--appendflag. More informa...
[uncategorized] ~507-~507: Did you mean “its” (the possessive pronoun)? (ITS_PREMIUM)
Context: ... allow users to query for an account by it's address. ```bash cosmos.auth.v1beta1.Q...
[uncategorized] ~690-~690: Did you mean “its” (the possessive pronoun)? (ITS_PREMIUM)
Context: ... allow users to query for an account by it's address. ```bash /cosmos/auth/v1beta1/...
Markdownlint
x/tx/CHANGELOG.md
142-142: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
143-143: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
150-150: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
151-151: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
152-152: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
153-153: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentationx/auth/README.md
21-21: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
23-23: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
26-26: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
29-29: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
30-30: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
31-31: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
432-432: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
71-71: Column: 20 (MD010, no-hard-tabs)
Hard tabs
103-103: Column: 1 (MD010, no-hard-tabs)
Hard tabs
105-105: Column: 1 (MD010, no-hard-tabs)
Hard tabs
106-106: Column: 1 (MD010, no-hard-tabs)
Hard tabs
108-108: Column: 1 (MD010, no-hard-tabs)
Hard tabs
109-109: Column: 1 (MD010, no-hard-tabs)
Hard tabs
111-111: Column: 1 (MD010, no-hard-tabs)
Hard tabs
112-112: Column: 1 (MD010, no-hard-tabs)
Hard tabs
114-114: Column: 1 (MD010, no-hard-tabs)
Hard tabs
115-115: Column: 1 (MD010, no-hard-tabs)
Hard tabs
117-117: Column: 1 (MD010, no-hard-tabs)
Hard tabs
118-118: Column: 1 (MD010, no-hard-tabs)
Hard tabs
192-192: Column: 1 (MD010, no-hard-tabs)
Hard tabs
193-193: Column: 1 (MD010, no-hard-tabs)
Hard tabs
195-195: Column: 1 (MD010, no-hard-tabs)
Hard tabs
196-196: Column: 1 (MD010, no-hard-tabs)
Hard tabs
198-198: Column: 1 (MD010, no-hard-tabs)
Hard tabs
199-199: Column: 1 (MD010, no-hard-tabs)
Hard tabs
201-201: Column: 1 (MD010, no-hard-tabs)
Hard tabs
202-202: Column: 1 (MD010, no-hard-tabs)
Hard tabs
204-204: Column: 1 (MD010, no-hard-tabs)
Hard tabs
205-205: Column: 1 (MD010, no-hard-tabs)
Hard tabs
207-207: Column: 1 (MD010, no-hard-tabs)
Hard tabs
208-208: Column: 1 (MD010, no-hard-tabs)
Hard tabs
210-210: Column: 1 (MD010, no-hard-tabs)
Hard tabs
211-211: Column: 1 (MD010, no-hard-tabs)
Hard tabs
213-213: Column: 1 (MD010, no-hard-tabs)
Hard tabs
214-214: Column: 1 (MD010, no-hard-tabs)
Hard tabs
216-216: Column: 1 (MD010, no-hard-tabs)
Hard tabs
217-217: Column: 1 (MD010, no-hard-tabs)
Hard tabs
219-219: Column: 1 (MD010, no-hard-tabs)
Hard tabs
220-220: Column: 1 (MD010, no-hard-tabs)
Hard tabs
500-500: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
Additional comments not posted (2)
x/tx/CHANGELOG.md (1)
38-38: The changelog entry is clear and concise, correctly summarizing the addition of the--skip-signature-verificationflag.x/auth/README.md (1)
450-465: The documentation clearly explains the process and necessity of using the--skip-signature-verificationflag for nested multisig transactions, including detailed CLI command examples.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- crypto/keys/multisig/multisig.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- crypto/keys/multisig/multisig.go
hieuvubk
approved these changes
Jun 14, 2024
julienrbrt
reviewed
Jun 17, 2024
| @@ -33,6 +33,10 @@ Since v0.13.0, x/tx follows Cosmos SDK semver: https://github.com/cosmos/cosmos- | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### Improvements | |||
There was a problem hiding this comment.
changelog is misplaced, this is a x/auth thing
|
@Mergifyio backport release/v0.50.x |
✅ Backports have been created
|
1 task
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
(cherry picked from commit b9ca318) # Conflicts: # x/auth/client/tx.go # x/tx/CHANGELOG.md
12 tasks
alpe
added a commit
that referenced
this pull request
Jun 17, 2024
* main: feat(tx): port simappv2 changes (#20648) build(deps): Bump github.com/spf13/cobra from 1.8.0 to 1.8.1 (#20682) chore(proto): fix comments (#20679) (serverv2/cometbft) Commands support both json and yaml output (#20670) fix(x/staking,x/auth): regenerate mock to fix test (#20684) docs: ADR 074: Msg v2 (#20618) fix: nested multisig signatures using CLI (#20438) chore: fix spelling errors (#20674) fix: align Dockerfile for build-push-action (#20672) fix: avoid build fail when make localnet-build-env (#20671) build(deps): Bump bufbuild/buf-setup-action from 1.32.2 to 1.33.0 (#20669) chore: make function comment match function names (#20666) chore(consensus): add cometInfo to consensus (#20615) chore: fix typos (#20662) fix: Properly parse json in the wait-tx command. (#20631) fix(sims): check before sending RotateConsPubKey (#20659) test(types/address): add unit tests for the file types/address.go (#20237)
julienrbrt
pushed a commit
that referenced
this pull request
Jun 19, 2024
12 tasks
Reecepbcups
pushed a commit
to rollchains/cosmos-sdk
that referenced
this pull request
Jul 19, 2024
* build(deps): Bump github.com/cosmos/gogoproto from 1.4.12 to 1.5.0 (cosmos#20567) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * refactor(x/authz,x/feegrant): provide updated keeper in depinject (cosmos#20590) * docs: Update high level overview and introduction (backport cosmos#20535) (cosmos#20627) Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: Properly parse json in the wait-tx command. (backport cosmos#20631) (cosmos#20660) Co-authored-by: Daniel Wedul <github@wedul.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * docs: remove Ineffective code block (backport cosmos#20703) (cosmos#20711) * feat(client): Add flag & reading mnemonic from file (backport cosmos#20690) (cosmos#20712) Co-authored-by: Hieu Vu <72878483+hieuvubk@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: nested multisig signatures using CLI (backport cosmos#20438) (cosmos#20692) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Facundo <facundomedica@gmail.com> * feat(client/v2): get keyring from context (backport cosmos#19646) (cosmos#20727) Co-authored-by: Julien Robert <julien@rbrt.fr> * docs(x/group): orm codespace comment (backport cosmos#20749) (cosmos#20751) * feat: parse home flag earlier (backport cosmos#20771) (cosmos#20777) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cometbft/cometbft from 0.38.7 to 0.38.8 (cosmos#20805) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * build(deps): Bump github.com/cometbft/cometbft from 0.38.8 to 0.38.9 (cosmos#20836) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(simulation): fix the problem of `validator set is empty after InitGenesis` in simulation test (backport cosmos#18196) (cosmos#20897) Co-authored-by: Chenqun Lu <luchenqun@qq.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(simulation): Fix all problems `make test-sim-custom-genesis-fast` for simulation test. (backport cosmos#17911) (cosmos#20909) Co-authored-by: Chenqun Lu <luchenqun@qq.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare v0.50.8 (cosmos#20910) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Daniel Wedul <github@wedul.com> Co-authored-by: Hieu Vu <72878483+hieuvubk@users.noreply.github.com> Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: Facundo <facundomedica@gmail.com> Co-authored-by: Chenqun Lu <luchenqun@qq.com>
facundomedica
added a commit
that referenced
this pull request
Jul 22, 2024
facundomedica
added a commit
that referenced
this pull request
Jul 22, 2024
mmsqe
added a commit
to crypto-org-chain/cosmos-sdk
that referenced
this pull request
Sep 30, 2024
* build(deps): Bump github.com/cosmos/gogoproto from 1.4.11 to 1.4.12 (cosmos#19811) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat(x/gov): emit proposer address in submit proposal event (backport cosmos#19842) (cosmos#19844) Co-authored-by: Aryan Tikarya <akaladarshi@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(x/gov): emit depositor in `proposal_deposit` event (backport cosmos#19853) (cosmos#19859) Co-authored-by: Kien <kien@notional.ventures> Co-authored-by: Julien Robert <julien@rbrt.fr> * reuse fromAddrString (minor cleanup) (cosmos#19881) * feat(client): replace `event-query-tx-for` with `wait-tx` (backport cosmos#19870) (cosmos#19887) * feat(server): add custom start handler (backport cosmos#19854) (cosmos#19884) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump cosmossdk.io/store from 1.0.2 to 1.1.0 (cosmos#19810) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * docs(x/mint): Fix inconsistency in mint docs (backport cosmos#19915) (cosmos#19925) * build(deps): Bump github.com/cosmos/iavl from 1.1.1 to 1.1.2 (cosmos#19985) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(client/v2): add encoder for `cosmos.base.v1beta1.DecCoin` (backport cosmos#19976) (cosmos#20001) Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(mempool): use no-op mempool as default (backport cosmos#19970) (cosmos#20008) Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: Conditionally emit metrics based on enablement (backport cosmos#19903) (cosmos#20017) Co-authored-by: Lucas Francisco López <lucaslopezf@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(x/bank): align query with multi denoms for send-enabled (backport cosmos#20028) (cosmos#20029) Co-authored-by: mmsqe <mavis@crypto.com> * fix: Implement gogoproto customtype to secp256r1 keys (backport cosmos#20027) (cosmos#20031) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> * fix(client/v2): respect output format from client ctx (backport cosmos#20033) (cosmos#20046) Co-authored-by: mmsqe <mavis@crypto.com> * build(deps): Bump cosmossdk.io/x/tx from 0.13.1 to 0.13.2 (cosmos#20042) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(x/bank): support depinject for send restrictions (backport cosmos#20014) (cosmos#20024) * fix(baseapp): don't share global gas meter in tx execution (backport cosmos#19616) (cosmos#20050) * fix: secp256r1 json missing quotes (backport cosmos#20060) (cosmos#20069) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> * build(deps): Bump github.com/cosmos/cosmos-proto from 1.0.0-beta.4 to 1.0.0-beta.5 (cosmos#20095) * feat(client/v2): implement version filtering using annotation (backport cosmos#20083) (cosmos#20099) Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare v0.50.6 (cosmos#19998) * fix: use timestamp for sim log file name (backport cosmos#20108) (cosmos#20111) Co-authored-by: mmsqe <mavis@crypto.com> * fix(x/authz,x/feegrant): check blocked address (cosmos#20102) * chore: update v0.50.6 release notes (cosmos#20124) * build(deps): bump sdk in modules (cosmos#20126) * docs(gas/fees): Update block gas documentation (backport cosmos#20128) (cosmos#20131) Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> * fix(baseapp): avoid header height overwrite block height (backport cosmos#20107) (cosmos#20129) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * docs: fix broken link (backport cosmos#20133) (cosmos#20138) * build(deps): bump modules in simapp (cosmos#20137) * build(deps): Bump cosmossdk.io/x/tx from 0.13.2 to 0.13.3 (cosmos#20152) * docs: add authz reference info in the circuit antehandler (backport cosmos#20146) (cosmos#20155) Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> * fix(testsuite/sims): set all signatures (backport cosmos#20151) (cosmos#20185) Co-authored-by: Leon <156270887+leonz789@users.noreply.github.com> * build(deps): Bump github.com/cometbft/cometbft from 0.38.6 to 0.38.7 (cosmos#20206) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(server): bootstrap-state command can't parse latest genesis format (backport cosmos#20020) (cosmos#20045) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: remove txs from mempool when antehandler fails in recheck (backport cosmos#20144) (cosmos#20251) Co-authored-by: Marko <marko@baricevic.me> * feat(baseapp): expose grpc query router via depinject. (cosmos#20264) * feat(client/v2): override short description in generated command (backport cosmos#20266) (cosmos#20269) Co-authored-by: John Letey <j@letey.de> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(runtime): Add missing NewTransientStoreService (backport cosmos#20261) (cosmos#20327) Co-authored-by: beer-1 <147697694+beer-1@users.noreply.github.com> * fix: allow tx decoding to fail in GetBlockWithTxs (backport cosmos#20323) (cosmos#20329) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix(client/v2): correctly check subcommand short descriptions (backport cosmos#20330) (cosmos#20340) * build(deps): Bump cosmossdk.io/api from 0.7.4 to 0.7.5 (cosmos#20338) * style: Fix gov query proposals examples syntax (backport cosmos#20353) (cosmos#20357) * feat(client): add consensus address for debug cmd (backport cosmos#20328) (cosmos#20366) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(client): overwrite client context instead of setting new one (backport cosmos#20356) (cosmos#20383) Co-authored-by: Shude Li <islishude@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: correctly assign `execModeSimulate` to context for `simulateTx` (backport cosmos#20342) (cosmos#20346) Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * docs: update diagram to be shown properly (backport cosmos#20454) (cosmos#20460) Co-authored-by: tianyeyouyou <150894831+tianyeyouyou@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * docs: fix note blocks display failure (backport cosmos#20457) (cosmos#20459) Co-authored-by: cocoyeal <150209682+cocoyeal@users.noreply.github.com> * docs: update link contents (backport cosmos#20437) (cosmos#20462) Co-authored-by: PolyMa <151764357+polymaer@users.noreply.github.com> * fix(x/consensus): harden consensus params proposal (cosmos#20381) Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> * docs: add docs on permissions (backport cosmos#20526) (cosmos#20527) Co-authored-by: Marko <marko@baricevic.me> * chore(x/upgrade): bump vulnerable `go-getter` library (cosmos#20530) * chore: prepare v0.50.7 (cosmos#20475) * build(deps): Bump github.com/cosmos/gogoproto from 1.4.12 to 1.5.0 (cosmos#20567) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * refactor(x/authz,x/feegrant): provide updated keeper in depinject (cosmos#20590) * docs: Update high level overview and introduction (backport cosmos#20535) (cosmos#20627) Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: Properly parse json in the wait-tx command. (backport cosmos#20631) (cosmos#20660) Co-authored-by: Daniel Wedul <github@wedul.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * docs: remove Ineffective code block (backport cosmos#20703) (cosmos#20711) * feat(client): Add flag & reading mnemonic from file (backport cosmos#20690) (cosmos#20712) Co-authored-by: Hieu Vu <72878483+hieuvubk@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: nested multisig signatures using CLI (backport cosmos#20438) (cosmos#20692) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Facundo <facundomedica@gmail.com> * feat(client/v2): get keyring from context (backport cosmos#19646) (cosmos#20727) Co-authored-by: Julien Robert <julien@rbrt.fr> * docs(x/group): orm codespace comment (backport cosmos#20749) (cosmos#20751) * feat: parse home flag earlier (backport cosmos#20771) (cosmos#20777) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cometbft/cometbft from 0.38.7 to 0.38.8 (cosmos#20805) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * build(deps): Bump github.com/cometbft/cometbft from 0.38.8 to 0.38.9 (cosmos#20836) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(simulation): fix the problem of `validator set is empty after InitGenesis` in simulation test (backport cosmos#18196) (cosmos#20897) Co-authored-by: Chenqun Lu <luchenqun@qq.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(simulation): Fix all problems `make test-sim-custom-genesis-fast` for simulation test. (backport cosmos#17911) (cosmos#20909) Co-authored-by: Chenqun Lu <luchenqun@qq.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare v0.50.8 (cosmos#20910) * chore(simapp): use tagged version (cosmos#20951) * fix: include pagination.key at reverse mode (backport cosmos#20939) (cosmos#20954) Co-authored-by: beer-1 <147697694+beer-1@users.noreply.github.com> Co-authored-by: Facundo <facundomedica@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cometbft/cometbft from 0.38.9 to 0.38.10 (cosmos#20960) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(client/v2): use (PREFIX)_HOME instead of NODE_HOME (backport cosmos#20964) (cosmos#20970) Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(client/grpc): `node.NewQueryServer` method not setting `cfg` (backport cosmos#20969) (cosmos#20973) * fix: NewIntegrationApp does not write default genesis to state (backport cosmos#21006) (cosmos#21008) Co-authored-by: son trinh <trinhleson2000@gmail.com> * fix(crypto): revert cosmos#20438 (cosmos#21019) * feat: use depinject v1.0.0 (cosmos#21000) * fix(runtime): remove `appv1alpha1.Config` from runtime (backport cosmos#21042) (cosmos#21080) Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * feat: check latest block if no arg in `q block` and `q block-results` (backport cosmos#21084) (cosmos#21111) Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> * fix(simapp): concurrent map writes when calling GetSigners (backport cosmos#21073) (cosmos#21130) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Facundo <facundomedica@gmail.com> * docs: Fix cli usage examples (backport cosmos#21150) (cosmos#21154) Co-authored-by: Christoph Otter <chipshort@tutanota.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: bring in v0.13.x x/tx in release/v0.50.x (cosmos#21158) * build(deps): Bump cosmossdk.io/x/tx from 0.13.3 to 0.13.4 (cosmos#21170) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(baseapp): return events from preblocker in FinalizeBlockResponse (backport cosmos#21159) (cosmos#21162) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Facundo <facundomedica@gmail.com> * chore: prepare v0.50.9 (cosmos#21163) * ci: attempt to fix goreleaser (backport cosmos#21194) (cosmos#21196) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump cosmossdk.io/log from 1.3.1 to 1.4.0 (cosmos#21209) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * chore: backport NewMemStoreService method (cosmos#21212) * build(deps): Bump github.com/cosmos/gogoproto from 1.5.0 to 1.6.0 (cosmos#21234) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat: module hash by height query (backport cosmos#20779) (cosmos#21247) Co-authored-by: Adam Tucker <adam@osmosis.team> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * build(deps): Bump github.com/cometbft/cometbft from 0.38.10 to 0.38.11 (cosmos#21264) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat(confix): allow customization of migration plan (backport cosmos#21202) (cosmos#21268) Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cosmos/gogoproto from 1.6.0 to 1.7.0 (cosmos#21294) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(baseapp)!: Halt at height now does not produce the halt height block (backport cosmos#21256) (cosmos#21323) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: Facundo <facundomedica@gmail.com> * chore: bring in core v0.11.x (v0.50 compatible) to v0.50 (cosmos#21298) * docs: rename app v2 to app di when talking about runtime v0 (backport cosmos#21329) (cosmos#21335) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump cosmossdk.io/log from 1.4.0 to 1.4.1 (cosmos#21351) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * docs: fix outdated link (backport cosmos#21397) (cosmos#21400) Co-authored-by: KI <KIVIKY@protonmail.com> * feat(x/bank): add origin address in event multisend (backport cosmos#21460) (cosmos#21465) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cosmos/ics23/go from 0.10.0 to 0.11.0 (cosmos#21473) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(baseapp): preblock events are not emmitted correctly (backport cosmos#21444) (cosmos#21458) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(x/consensus)!: update cons params parsing checks (backport cosmos#21484) (cosmos#21493) Co-authored-by: MSalopek <matija.salopek994@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(types/mempool): fix slice init length (backport cosmos#21494) (cosmos#21519) Co-authored-by: dropbigfish <fillfish@foxmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cometbft/cometbft from 0.38.11 to 0.38.12 (cosmos#21535) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(x/genutil): bulk add genesis accounts (backport cosmos#21372) (cosmos#21544) Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> Co-authored-by: Reece Williams <reecepbcups@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(mempool): data race in mempool prepare proposal handler (backport cosmos#21413) (cosmos#21541) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): bump iavl in cosmossdk.io/store 1.1.x (cosmos#21574) * docs(x/evidence): fix evidence module subcommands help message (backport cosmos#21589) (cosmos#21592) * docs(client/debug): correct and improve `debug pubkey-raw` command example (backport cosmos#21594) (cosmos#21600) Co-authored-by: lilasxie <thanklilas@163.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * docs(client/debug): correct `debug raw-bytes` command example (backport cosmos#21671) (cosmos#21676) Co-authored-by: lilasxie <thanklilas@163.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * docs(x/authz): update grant docs (backport cosmos#21677) (cosmos#21700) Co-authored-by: Eric Mokaya <4112301+ziscky@users.noreply.github.com> Co-authored-by: Akhil Kumar P <36399231+akhilkumarpilli@users.noreply.github.com> * feat(x/genutil): add better error messages for genesis validation (backport cosmos#21701) (cosmos#21708) Co-authored-by: Eric Mokaya <4112301+ziscky@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * feat(types/collections): add `LegacyDec` collection value (backport cosmos#21693) (cosmos#21724) Co-authored-by: John Letey <john@noble.xyz> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> * docs: demonstrate how to wire custom ante handlers in 0.50 app_di (cosmos#21767) * docs(x/circuit): display correct example (backport cosmos#21768) (cosmos#21773) Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(runtime): fix option order (backport cosmos#21769) (cosmos#21771) Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare v0.50.10 (cosmos#21498) * feat(x/tx): add `aminoNameAsTypeURL` option in aminojson encoder (backport cosmos#21712) (cosmos#21798) Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(client/v2): use x/tx `AminoNameAsTypeURL` option in 0.50 (cosmos#21801) * feat(testutil/integration): allow to pass baseapp options (backport cosmos#21816) (cosmos#21818) Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * chore: correct date cl v0.50.10 (cosmos#21832) * feat(crypto/keyring): add Linux's keyctl support (backport cosmos#21653) (cosmos#21840) Co-authored-by: Alessio Treglia <al@essio.dev> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(x/staking): query redelegation command (backport cosmos#21856) (cosmos#21861) Co-authored-by: Akhil Kumar P <36399231+akhilkumarpilli@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore(docs): rename merlin to simapp (backport cosmos#21884) (cosmos#21886) Co-authored-by: Marko <marko@baricevic.me> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix(cli): avoid id isn't supported error when query address-by-acc-num (backport cosmos#21919) (cosmos#21922) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(sims): Skip sims test when running dry on validators (backport cosmos#21906) (cosmos#21910) Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(client/v2): correctly handle enhanced sub commands (backport cosmos#21809) (cosmos#21930) Co-authored-by: John Letey <john@noble.xyz> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(client/v2): improve error message on enums (backport cosmos#21936) (cosmos#21938) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: regenerate addrbook.json for in-place-testnet (backport cosmos#21941) (cosmos#21947) Co-authored-by: Adam Tucker <adam@osmosis.team> Co-authored-by: Julien Robert <julien@rbrt.fr> * align thresholdStringEncoder --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Aryan Tikarya <akaladarshi@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Kien <kien@notional.ventures> Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: Lucas Francisco López <lucaslopezf@gmail.com> Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> Co-authored-by: Leon <156270887+leonz789@users.noreply.github.com> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> Co-authored-by: Marko <marko@baricevic.me> Co-authored-by: John Letey <j@letey.de> Co-authored-by: beer-1 <147697694+beer-1@users.noreply.github.com> Co-authored-by: Shude Li <islishude@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: tianyeyouyou <150894831+tianyeyouyou@users.noreply.github.com> Co-authored-by: cocoyeal <150209682+cocoyeal@users.noreply.github.com> Co-authored-by: PolyMa <151764357+polymaer@users.noreply.github.com> Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Daniel Wedul <github@wedul.com> Co-authored-by: Hieu Vu <72878483+hieuvubk@users.noreply.github.com> Co-authored-by: Facundo <facundomedica@gmail.com> Co-authored-by: Chenqun Lu <luchenqun@qq.com> Co-authored-by: Christoph Otter <chipshort@tutanota.com> Co-authored-by: Adam Tucker <adam@osmosis.team> Co-authored-by: KI <KIVIKY@protonmail.com> Co-authored-by: MSalopek <matija.salopek994@gmail.com> Co-authored-by: dropbigfish <fillfish@foxmail.com> Co-authored-by: Reece Williams <reecepbcups@gmail.com> Co-authored-by: lilasxie <thanklilas@163.com> Co-authored-by: Eric Mokaya <4112301+ziscky@users.noreply.github.com> Co-authored-by: Akhil Kumar P <36399231+akhilkumarpilli@users.noreply.github.com> Co-authored-by: John Letey <john@noble.xyz> Co-authored-by: Alessio Treglia <al@essio.dev> Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>
SpicyLemon
added a commit
to provenance-io/cosmos-sdk
that referenced
this pull request
Oct 10, 2024
* fix(crypto): error if incorrect ledger public key (backport cosmos#19691) (cosmos#19745) Co-authored-by: Rootul P <rootulp@gmail.com> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> * build(deps): Bump github.com/cometbft/cometbft from 0.38.5 to 0.38.6 (cosmos#19751) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix: align signer extraction adapter for mempool remove (backport cosmos#19759) (cosmos#19773) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix(x/upgrade): Stop treating inline JSON as a URL (backport cosmos#19706) (cosmos#19767) Co-authored-by: Richard Gibson <richard.gibson@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix(client/v2): fix comment parsing (backport cosmos#19377) (cosmos#19777) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cosmos/iavl from 1.0.1 to 1.1.1 in store (cosmos#19770) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Cool Developer <cool199966@outlook.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore(store): add release date (cosmos#19797) * build(deps): Bump github.com/cosmos/gogoproto from 1.4.11 to 1.4.12 (cosmos#19811) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat(x/gov): emit proposer address in submit proposal event (backport cosmos#19842) (cosmos#19844) Co-authored-by: Aryan Tikarya <akaladarshi@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(x/gov): emit depositor in `proposal_deposit` event (backport cosmos#19853) (cosmos#19859) Co-authored-by: Kien <kien@notional.ventures> Co-authored-by: Julien Robert <julien@rbrt.fr> * reuse fromAddrString (minor cleanup) (cosmos#19881) * feat(client): replace `event-query-tx-for` with `wait-tx` (backport cosmos#19870) (cosmos#19887) * feat(server): add custom start handler (backport cosmos#19854) (cosmos#19884) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump cosmossdk.io/store from 1.0.2 to 1.1.0 (cosmos#19810) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * docs(x/mint): Fix inconsistency in mint docs (backport cosmos#19915) (cosmos#19925) * build(deps): Bump github.com/cosmos/iavl from 1.1.1 to 1.1.2 (cosmos#19985) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(client/v2): add encoder for `cosmos.base.v1beta1.DecCoin` (backport cosmos#19976) (cosmos#20001) Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(mempool): use no-op mempool as default (backport cosmos#19970) (cosmos#20008) Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: Conditionally emit metrics based on enablement (backport cosmos#19903) (cosmos#20017) Co-authored-by: Lucas Francisco López <lucaslopezf@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(x/bank): align query with multi denoms for send-enabled (backport cosmos#20028) (cosmos#20029) Co-authored-by: mmsqe <mavis@crypto.com> * fix: Implement gogoproto customtype to secp256r1 keys (backport cosmos#20027) (cosmos#20031) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> * fix(client/v2): respect output format from client ctx (backport cosmos#20033) (cosmos#20046) Co-authored-by: mmsqe <mavis@crypto.com> * build(deps): Bump cosmossdk.io/x/tx from 0.13.1 to 0.13.2 (cosmos#20042) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(x/bank): support depinject for send restrictions (backport cosmos#20014) (cosmos#20024) * fix(baseapp): don't share global gas meter in tx execution (backport cosmos#19616) (cosmos#20050) * fix: secp256r1 json missing quotes (backport cosmos#20060) (cosmos#20069) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> * build(deps): Bump github.com/cosmos/cosmos-proto from 1.0.0-beta.4 to 1.0.0-beta.5 (cosmos#20095) * feat(client/v2): implement version filtering using annotation (backport cosmos#20083) (cosmos#20099) Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare v0.50.6 (cosmos#19998) * fix: use timestamp for sim log file name (backport cosmos#20108) (cosmos#20111) Co-authored-by: mmsqe <mavis@crypto.com> * fix(x/authz,x/feegrant): check blocked address (cosmos#20102) * chore: update v0.50.6 release notes (cosmos#20124) * build(deps): bump sdk in modules (cosmos#20126) * docs(gas/fees): Update block gas documentation (backport cosmos#20128) (cosmos#20131) Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> * fix(baseapp): avoid header height overwrite block height (backport cosmos#20107) (cosmos#20129) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * docs: fix broken link (backport cosmos#20133) (cosmos#20138) * build(deps): bump modules in simapp (cosmos#20137) * build(deps): Bump cosmossdk.io/x/tx from 0.13.2 to 0.13.3 (cosmos#20152) * docs: add authz reference info in the circuit antehandler (backport cosmos#20146) (cosmos#20155) Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> * fix(testsuite/sims): set all signatures (backport cosmos#20151) (cosmos#20185) Co-authored-by: Leon <156270887+leonz789@users.noreply.github.com> * build(deps): Bump github.com/cometbft/cometbft from 0.38.6 to 0.38.7 (cosmos#20206) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(server): bootstrap-state command can't parse latest genesis format (backport cosmos#20020) (cosmos#20045) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: remove txs from mempool when antehandler fails in recheck (backport cosmos#20144) (cosmos#20251) Co-authored-by: Marko <marko@baricevic.me> * feat(baseapp): expose grpc query router via depinject. (cosmos#20264) * feat(client/v2): override short description in generated command (backport cosmos#20266) (cosmos#20269) Co-authored-by: John Letey <j@letey.de> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(runtime): Add missing NewTransientStoreService (backport cosmos#20261) (cosmos#20327) Co-authored-by: beer-1 <147697694+beer-1@users.noreply.github.com> * fix: allow tx decoding to fail in GetBlockWithTxs (backport cosmos#20323) (cosmos#20329) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix(client/v2): correctly check subcommand short descriptions (backport cosmos#20330) (cosmos#20340) * build(deps): Bump cosmossdk.io/api from 0.7.4 to 0.7.5 (cosmos#20338) * style: Fix gov query proposals examples syntax (backport cosmos#20353) (cosmos#20357) * feat(client): add consensus address for debug cmd (backport cosmos#20328) (cosmos#20366) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(client): overwrite client context instead of setting new one (backport cosmos#20356) (cosmos#20383) Co-authored-by: Shude Li <islishude@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: correctly assign `execModeSimulate` to context for `simulateTx` (backport cosmos#20342) (cosmos#20346) Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * docs: update diagram to be shown properly (backport cosmos#20454) (cosmos#20460) Co-authored-by: tianyeyouyou <150894831+tianyeyouyou@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * docs: fix note blocks display failure (backport cosmos#20457) (cosmos#20459) Co-authored-by: cocoyeal <150209682+cocoyeal@users.noreply.github.com> * docs: update link contents (backport cosmos#20437) (cosmos#20462) Co-authored-by: PolyMa <151764357+polymaer@users.noreply.github.com> * fix(x/consensus): harden consensus params proposal (cosmos#20381) Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> * docs: add docs on permissions (backport cosmos#20526) (cosmos#20527) Co-authored-by: Marko <marko@baricevic.me> * chore(x/upgrade): bump vulnerable `go-getter` library (cosmos#20530) * chore: prepare v0.50.7 (cosmos#20475) * build(deps): Bump github.com/cosmos/gogoproto from 1.4.12 to 1.5.0 (cosmos#20567) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * refactor(x/authz,x/feegrant): provide updated keeper in depinject (cosmos#20590) * docs: Update high level overview and introduction (backport cosmos#20535) (cosmos#20627) Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: Properly parse json in the wait-tx command. (backport cosmos#20631) (cosmos#20660) Co-authored-by: Daniel Wedul <github@wedul.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * docs: remove Ineffective code block (backport cosmos#20703) (cosmos#20711) * feat(client): Add flag & reading mnemonic from file (backport cosmos#20690) (cosmos#20712) Co-authored-by: Hieu Vu <72878483+hieuvubk@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: nested multisig signatures using CLI (backport cosmos#20438) (cosmos#20692) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Facundo <facundomedica@gmail.com> * feat(client/v2): get keyring from context (backport cosmos#19646) (cosmos#20727) Co-authored-by: Julien Robert <julien@rbrt.fr> * docs(x/group): orm codespace comment (backport cosmos#20749) (cosmos#20751) * feat: parse home flag earlier (backport cosmos#20771) (cosmos#20777) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cometbft/cometbft from 0.38.7 to 0.38.8 (cosmos#20805) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * build(deps): Bump github.com/cometbft/cometbft from 0.38.8 to 0.38.9 (cosmos#20836) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(simulation): fix the problem of `validator set is empty after InitGenesis` in simulation test (backport cosmos#18196) (cosmos#20897) Co-authored-by: Chenqun Lu <luchenqun@qq.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(simulation): Fix all problems `make test-sim-custom-genesis-fast` for simulation test. (backport cosmos#17911) (cosmos#20909) Co-authored-by: Chenqun Lu <luchenqun@qq.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare v0.50.8 (cosmos#20910) * chore(simapp): use tagged version (cosmos#20951) * fix: include pagination.key at reverse mode (backport cosmos#20939) (cosmos#20954) Co-authored-by: beer-1 <147697694+beer-1@users.noreply.github.com> Co-authored-by: Facundo <facundomedica@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cometbft/cometbft from 0.38.9 to 0.38.10 (cosmos#20960) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(client/v2): use (PREFIX)_HOME instead of NODE_HOME (backport cosmos#20964) (cosmos#20970) Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(client/grpc): `node.NewQueryServer` method not setting `cfg` (backport cosmos#20969) (cosmos#20973) * fix: NewIntegrationApp does not write default genesis to state (backport cosmos#21006) (cosmos#21008) Co-authored-by: son trinh <trinhleson2000@gmail.com> * fix(crypto): revert cosmos#20438 (cosmos#21019) * feat: use depinject v1.0.0 (cosmos#21000) * fix(runtime): remove `appv1alpha1.Config` from runtime (backport cosmos#21042) (cosmos#21080) Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * feat: check latest block if no arg in `q block` and `q block-results` (backport cosmos#21084) (cosmos#21111) Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> * fix(simapp): concurrent map writes when calling GetSigners (backport cosmos#21073) (cosmos#21130) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Facundo <facundomedica@gmail.com> * docs: Fix cli usage examples (backport cosmos#21150) (cosmos#21154) Co-authored-by: Christoph Otter <chipshort@tutanota.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: bring in v0.13.x x/tx in release/v0.50.x (cosmos#21158) * build(deps): Bump cosmossdk.io/x/tx from 0.13.3 to 0.13.4 (cosmos#21170) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(baseapp): return events from preblocker in FinalizeBlockResponse (backport cosmos#21159) (cosmos#21162) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Facundo <facundomedica@gmail.com> * chore: prepare v0.50.9 (cosmos#21163) * ci: attempt to fix goreleaser (backport cosmos#21194) (cosmos#21196) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump cosmossdk.io/log from 1.3.1 to 1.4.0 (cosmos#21209) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * chore: backport NewMemStoreService method (cosmos#21212) * build(deps): Bump github.com/cosmos/gogoproto from 1.5.0 to 1.6.0 (cosmos#21234) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat: module hash by height query (backport cosmos#20779) (cosmos#21247) Co-authored-by: Adam Tucker <adam@osmosis.team> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * build(deps): Bump github.com/cometbft/cometbft from 0.38.10 to 0.38.11 (cosmos#21264) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat(confix): allow customization of migration plan (backport cosmos#21202) (cosmos#21268) Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cosmos/gogoproto from 1.6.0 to 1.7.0 (cosmos#21294) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(baseapp)!: Halt at height now does not produce the halt height block (backport cosmos#21256) (cosmos#21323) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: Facundo <facundomedica@gmail.com> * chore: bring in core v0.11.x (v0.50 compatible) to v0.50 (cosmos#21298) * docs: rename app v2 to app di when talking about runtime v0 (backport cosmos#21329) (cosmos#21335) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump cosmossdk.io/log from 1.4.0 to 1.4.1 (cosmos#21351) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * docs: fix outdated link (backport cosmos#21397) (cosmos#21400) Co-authored-by: KI <KIVIKY@protonmail.com> * feat(x/bank): add origin address in event multisend (backport cosmos#21460) (cosmos#21465) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cosmos/ics23/go from 0.10.0 to 0.11.0 (cosmos#21473) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(baseapp): preblock events are not emmitted correctly (backport cosmos#21444) (cosmos#21458) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(x/consensus)!: update cons params parsing checks (backport cosmos#21484) (cosmos#21493) Co-authored-by: MSalopek <matija.salopek994@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(types/mempool): fix slice init length (backport cosmos#21494) (cosmos#21519) Co-authored-by: dropbigfish <fillfish@foxmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cometbft/cometbft from 0.38.11 to 0.38.12 (cosmos#21535) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(x/genutil): bulk add genesis accounts (backport cosmos#21372) (cosmos#21544) Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> Co-authored-by: Reece Williams <reecepbcups@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(mempool): data race in mempool prepare proposal handler (backport cosmos#21413) (cosmos#21541) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): bump iavl in cosmossdk.io/store 1.1.x (cosmos#21574) * docs(x/evidence): fix evidence module subcommands help message (backport cosmos#21589) (cosmos#21592) * docs(client/debug): correct and improve `debug pubkey-raw` command example (backport cosmos#21594) (cosmos#21600) Co-authored-by: lilasxie <thanklilas@163.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * docs(client/debug): correct `debug raw-bytes` command example (backport cosmos#21671) (cosmos#21676) Co-authored-by: lilasxie <thanklilas@163.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * docs(x/authz): update grant docs (backport cosmos#21677) (cosmos#21700) Co-authored-by: Eric Mokaya <4112301+ziscky@users.noreply.github.com> Co-authored-by: Akhil Kumar P <36399231+akhilkumarpilli@users.noreply.github.com> * feat(x/genutil): add better error messages for genesis validation (backport cosmos#21701) (cosmos#21708) Co-authored-by: Eric Mokaya <4112301+ziscky@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * feat(types/collections): add `LegacyDec` collection value (backport cosmos#21693) (cosmos#21724) Co-authored-by: John Letey <john@noble.xyz> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> * docs: demonstrate how to wire custom ante handlers in 0.50 app_di (cosmos#21767) * docs(x/circuit): display correct example (backport cosmos#21768) (cosmos#21773) Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(runtime): fix option order (backport cosmos#21769) (cosmos#21771) Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare v0.50.10 (cosmos#21498) * feat(x/tx): add `aminoNameAsTypeURL` option in aminojson encoder (backport cosmos#21712) (cosmos#21798) Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(client/v2): use x/tx `AminoNameAsTypeURL` option in 0.50 (cosmos#21801) * feat(testutil/integration): allow to pass baseapp options (backport cosmos#21816) (cosmos#21818) Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * chore: correct date cl v0.50.10 (cosmos#21832) * Add the sender to the InputOutputCoins transfer events. The SDK did this in PR cosmos#21460 and I undid it when merging in the v0.50.10 changes since it's more complicated for us than the SDK. So this is bringing us back in line with SDK v0.50.10 with slightly different event ordering. This change also reduces the amount of times subUnlockedCoins is called when there are multiple inputs with the same address. * Add changelog entry. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Rootul P <rootulp@gmail.com> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Richard Gibson <richard.gibson@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Cool Developer <cool199966@outlook.com> Co-authored-by: Aryan Tikarya <akaladarshi@gmail.com> Co-authored-by: Kien <kien@notional.ventures> Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: Lucas Francisco López <lucaslopezf@gmail.com> Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> Co-authored-by: Leon <156270887+leonz789@users.noreply.github.com> Co-authored-by: Marko <marko@baricevic.me> Co-authored-by: John Letey <j@letey.de> Co-authored-by: beer-1 <147697694+beer-1@users.noreply.github.com> Co-authored-by: Shude Li <islishude@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: tianyeyouyou <150894831+tianyeyouyou@users.noreply.github.com> Co-authored-by: cocoyeal <150209682+cocoyeal@users.noreply.github.com> Co-authored-by: PolyMa <151764357+polymaer@users.noreply.github.com> Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Hieu Vu <72878483+hieuvubk@users.noreply.github.com> Co-authored-by: Facundo <facundomedica@gmail.com> Co-authored-by: Chenqun Lu <luchenqun@qq.com> Co-authored-by: Christoph Otter <chipshort@tutanota.com> Co-authored-by: Adam Tucker <adam@osmosis.team> Co-authored-by: KI <KIVIKY@protonmail.com> Co-authored-by: MSalopek <matija.salopek994@gmail.com> Co-authored-by: dropbigfish <fillfish@foxmail.com> Co-authored-by: Reece Williams <reecepbcups@gmail.com> Co-authored-by: lilasxie <thanklilas@163.com> Co-authored-by: Eric Mokaya <4112301+ziscky@users.noreply.github.com> Co-authored-by: Akhil Kumar P <36399231+akhilkumarpilli@users.noreply.github.com> Co-authored-by: John Letey <john@noble.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #20355 and #20382
This PR enables the CLI to sign nested multisig txs, by modifying how the signer check is done and adding a flag to disable signature verification. Also #20404 was included here.
It was tested with 4 common accounts (alice, bob, carol and dave) forming 3 multisigs: ms1 (alice, bob), ms2 (bob, carol) and ms3 (bob, dave, ms1, ms2). Then a tx from ms3 is created and signed by all the participants.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
New Features
--skip-signature-verificationflag for multisig transactions, allowing users to skip signature verification.Bug Fixes
packPubKeysfunction to correctly unmarshal public keys.Tests
Documentation
--skip-signature-verificationflag.