Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix several typos in the document #22066

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

xiaobei0715
Copy link
Contributor

@xiaobei0715 xiaobei0715 commented Oct 3, 2024

fix several typos in the document

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Documentation
    • Improved clarity and consistency in the PROCESS.md document through grammatical adjustments and refined descriptions.

fix several typos in the document
@xiaobei0715 xiaobei0715 requested a review from a team as a code owner October 3, 2024 08:26
Copy link
Contributor

coderabbitai bot commented Oct 3, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The changes in this pull request primarily involve textual modifications to the PROCESS.md document. These modifications aim to enhance clarity and grammatical correctness through minor adjustments, including subject-verb agreement corrections and refinements in the descriptions of ADR statuses. The overall focus is on improving readability without altering the document's content or structure.

Changes

File Change Summary
docs/architecture/PROCESS.md Minor grammatical adjustments for clarity, including subject-verb agreement corrections and refined ADR status descriptions.

Possibly related PRs

  • docs(x/gov): fix typos #21588: The changes in this PR involve grammatical corrections and minor rephrasing in documentation, similar to the focus on clarity and grammatical accuracy in the main PR.
  • docs: fix typo #21815: This PR addresses typographical errors in documentation, specifically correcting "demon" to "denom," which aligns with the main PR's goal of enhancing clarity and correctness.
  • docs: fix several typos in the document #22052: This PR also focuses on fixing multiple typographical errors in documentation, which is directly related to the main PR's emphasis on grammatical accuracy and clarity.

Suggested labels

backport/v0.52.x

Suggested reviewers

  • sontrinh16

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@julienrbrt julienrbrt changed the title fix several typos in the document docs: fix several typos in the document Oct 3, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
docs/architecture/PROCESS.md (1)

49-49: Approved with suggestion: Grammar improvement and clarity enhancement

The change from "Clear notify" to "Clear notification" improves the grammar and clarity of the sentence. However, to further enhance readability, consider rephrasing the beginning of the sentence:

- * `LAST CALL <date for the last call>`: [optional] Clear notification that we are close to accepting updates.
+ * `LAST CALL <date for the last call>`: [optional] Provides clear notification that we are close to accepting updates.

This adjustment makes the sentence structure more consistent with the other bullet points in the list.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~49-~49: Loose punctuation mark.
Context: .... * LAST CALL <date for the last call>: [optional] Clear notify that we are clo...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~49-~49: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...Cosmos SDK maintainers) has been reached and we still want to give it a time to let ...

(COMMA_COMPOUND_SENTENCE)


[style] ~49-~49: Consider replacing ‘give’ with a different word to let your writing stand out.
Context: ...) has been reached and we still want to give it a time to let the community react or an...

(GIVE_TIME_STYLE)

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 4e6a43b and fffae00.

📒 Files selected for processing (1)
  • docs/architecture/PROCESS.md (3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
docs/architecture/PROCESS.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

🪛 LanguageTool
docs/architecture/PROCESS.md

[uncategorized] ~47-~47: Loose punctuation mark.
Context: ... ABANDONED ``` * DRAFT: [optional] an ADR which is a work in pr...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~48-~48: Loose punctuation mark.
Context: ... a Draft Pull Request form. * PROPOSED: an ADR covering a full solution archite...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~49-~49: Loose punctuation mark.
Context: .... * LAST CALL <date for the last call>: [optional] Clear notify that we are clo...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~49-~49: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...Cosmos SDK maintainers) has been reached and we still want to give it a time to let ...

(COMMA_COMPOUND_SENTENCE)


[style] ~49-~49: Consider replacing ‘give’ with a different word to let your writing stand out.
Context: ...) has been reached and we still want to give it a time to let the community react or an...

(GIVE_TIME_STYLE)

🔇 Additional comments (4)
docs/architecture/PROCESS.md (4)

4-4: Approved: Grammar improvement

The removal of the article "an" before "early feedback" improves the grammar and makes the phrase more idiomatic. This change enhances the clarity of the documentation.


5-5: Approved: Corrected subject-verb agreement

The change from "is" to "are" correctly addresses the subject-verb agreement. "Context and solution" is a plural subject, so "are" is the appropriate verb form. This improvement enhances the grammatical accuracy of the documentation.


17-17: No visible changes detected

There are no apparent changes in this line. The mentioned alteration from "consensus has been met" to "consensus has been met" is not visible in the provided diff. This could be due to an error in the AI summary or a change that was subsequently reverted.


48-48: Approved: Improved phrase clarity

The change from "haven't reached an agreed yet" to "haven't reached an agreement yet" is a grammatical improvement. It correctly uses the noun "agreement" instead of the adjective "agreed", making the sentence more clear and grammatically correct.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~48-~48: Loose punctuation mark.
Context: ... a Draft Pull Request form. * PROPOSED: an ADR covering a full solution archite...

(UNLIKELY_OPENING_PUNCTUATION)

@julienrbrt julienrbrt added the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Oct 3, 2024
@julienrbrt julienrbrt enabled auto-merge October 3, 2024 09:08
@julienrbrt julienrbrt added this pull request to the merge queue Oct 3, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
docs/architecture/PROCESS.md (1)

48-49: Grammatical improvements approved with a minor suggestion

The changes on these lines significantly improve grammar and clarity:

  1. Line 48: "reached an agreement" is the correct phrase, replacing the incorrect "reached an agreed".
  2. Line 49: Removing "clear" before "Notify" improves conciseness.

These changes are approved. However, I have a minor suggestion to further improve clarity:

Consider adding a comma after "reached" on line 49 to separate the two independent clauses:

- * `LAST CALL <date for the last call>`: [optional] Notify that we are close to accepting updates. Changing a status to `LAST CALL` means that social consensus (of Cosmos SDK maintainers) has been reached and we still want to give it a time to let the community react or analyze.
+ * `LAST CALL <date for the last call>`: [optional] Notify that we are close to accepting updates. Changing a status to `LAST CALL` means that social consensus (of Cosmos SDK maintainers) has been reached, and we still want to give it time to let the community react or analyze.

This change would improve readability and adhere to the comma usage rule for compound sentences.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~48-~48: Loose punctuation mark.
Context: ... a Draft Pull Request form. * PROPOSED: an ADR covering a full solution archite...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~49-~49: Loose punctuation mark.
Context: .... * LAST CALL <date for the last call>: [optional] Notify that we are close to ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~49-~49: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...Cosmos SDK maintainers) has been reached and we still want to give it a time to let ...

(COMMA_COMPOUND_SENTENCE)


[style] ~49-~49: Consider replacing ‘give’ with a different word to let your writing stand out.
Context: ...) has been reached and we still want to give it a time to let the community react or an...

(GIVE_TIME_STYLE)

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between fffae00 and 351f37d.

📒 Files selected for processing (1)
  • docs/architecture/PROCESS.md (3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
docs/architecture/PROCESS.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

🪛 LanguageTool
docs/architecture/PROCESS.md

[uncategorized] ~47-~47: Loose punctuation mark.
Context: ... ABANDONED ``` * DRAFT: [optional] an ADR which is a work in pr...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~48-~48: Loose punctuation mark.
Context: ... a Draft Pull Request form. * PROPOSED: an ADR covering a full solution archite...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~49-~49: Loose punctuation mark.
Context: .... * LAST CALL <date for the last call>: [optional] Notify that we are close to ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~49-~49: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...Cosmos SDK maintainers) has been reached and we still want to give it a time to let ...

(COMMA_COMPOUND_SENTENCE)


[style] ~49-~49: Consider replacing ‘give’ with a different word to let your writing stand out.
Context: ...) has been reached and we still want to give it a time to let the community react or an...

(GIVE_TIME_STYLE)

🔇 Additional comments (2)
docs/architecture/PROCESS.md (2)

4-4: Grammatical improvement approved

The removal of "an" before "early feedback" is correct. "Feedback" is an uncountable noun and doesn't require an article in this context.


5-5: Subject-verb agreement correction approved

The change from "is" to "are" correctly addresses the subject-verb agreement. Since "context and solution" is a plural subject, "are" is the appropriate verb form.

Merged via the queue into cosmos:main with commit 947ffe0 Oct 3, 2024
71 of 73 checks passed
mergify bot pushed a commit that referenced this pull request Oct 3, 2024
Co-authored-by: Julien Robert <julien@rbrt.fr>
(cherry picked from commit 947ffe0)
julienrbrt pushed a commit that referenced this pull request Oct 3, 2024
Co-authored-by: XiaoBei <1505929057@qq.com>
@coderabbitai coderabbitai bot mentioned this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release Type: ADR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants