-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fixed typo in threshold and quorums section of onchain multi-sig guide in user guide section of sdk docs #22374
Conversation
pratikpatil2001
commented
Oct 26, 2024
•
edited
Loading
edited
📝 WalkthroughWalkthroughThe document Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
docs/user/run-node/08-onchain-multisig.md (1)
17-17
: Approve the typo fix with a minor suggestion for clarity.The correction improves the explanation of threshold vs quorum. To make it even clearer, consider adding an example:
-threshold is the minimum of voting power of YES votes to pass a proposal. +threshold is the minimum voting power of YES votes required to pass a proposal. For example, with 3 members having 1000 weight each and a threshold of 2000, at least 2 members must vote YES for the proposal to pass.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
📒 Files selected for processing (1)
- docs/user/run-node/08-onchain-multisig.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
docs/user/run-node/08-onchain-multisig.md (1)
Pattern
**/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"