Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(x/tx): update changelog to alpha.2 #22465

Merged
merged 1 commit into from
Nov 7, 2024
Merged

chore(x/tx): update changelog to alpha.2 #22465

merged 1 commit into from
Nov 7, 2024

Conversation

JulianToledano
Copy link
Contributor

@JulianToledano JulianToledano commented Nov 7, 2024 •
edited by coderabbitai bot
Loading

Description

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Changelog Updates
    • Added a new version entry for v1.0.0-alpha.2 (2024-11-01) documenting a fix related to feePayer as a signer.
    • Updated the previous version entry for v1.0.0-alpha.1 to remove the mention of the same fix.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 7, 2024 •
edited
Loading

📝 Walkthrough

Walkthrough

The changes include an update to the CHANGELOG.md file for the x/tx module, introducing a new version entry for v1.0.0-alpha.2 dated 2024-11-01. This entry documents a fix related to adding feePayer as a signer, which is referenced from pull request #22311. Additionally, the previous version entry for v1.0.0-alpha.1 has been modified to remove the mention of this fix, which has been appropriately moved to the new version entry.

Changes

File Change Summary
x/tx/CHANGELOG.md - Added new version entry for v1.0.0-alpha.2 (2024-11-01) documenting the fix for feePayer as a signer.
- Removed reference to the same fix from v1.0.0-alpha.1 (2024-10-17).

Possibly related PRs

  • fix(x/tx): add feePayer as signer #22311: This PR directly addresses the addition of feePayer as a signer in the transaction process, which is the main focus of the changes documented in the main PR's changelog update.

Suggested labels

backport/v0.52.x

Suggested reviewers

  • julienrbrt
  • testinginprod
  • kocubinski
📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6caa237 and ce46d27.

📒 Files selected for processing (1)
  • x/tx/CHANGELOG.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
x/tx/CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

🔇 Additional comments (1)
x/tx/CHANGELOG.md (1)

36-39: LGTM! The new version entry follows the changelog guidelines.

The new version entry:

  • Follows the correct format with proper version link
  • Includes the correct date
  • Maintains chronological order (latest version first)
  • Uses proper reference format for the fix entry

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the C:x/tx label Nov 7, 2024
@julienrbrt
Copy link
Member

thanks! i'll tag once this is merged.

@julienrbrt julienrbrt added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit f6c7ab6 Nov 7, 2024
77 checks passed
@julienrbrt julienrbrt deleted the julian/x-tx-changelog branch November 7, 2024 11:06
@julienrbrt
Copy link
Member

https://github.com/cosmos/cosmos-sdk/releases/tag/x%2Ftx%2Fv1.0.0-alpha.2

@coderabbitai coderabbitai bot mentioned this pull request Nov 8, 2024
Merged
12 tasks
alpe added a commit that referenced this pull request Nov 13, 2024
@alpe
Merge branch 'main' into alex/sam/dec-type
a00c36a 
* main: (31 commits)
  docs: update links for https security protocol (#22514)
  build(deps): Bump github.com/bytedance/sonic from 1.12.3 to 1.12.4 in /log (#22513)
  feat(x/protocolpool)!: allow any coins in continuous funds (#21916)
  docs: Update protobuf  tx signing message format outer link (#22510)
  test(accounts): fix integration tests (#22418)
  chore(x): fix some typos in comment (#22508)
  build(deps): Bump cosmossdk.io/log from 1.4.1 to 1.5.0 (#22487)
  build(deps): Bump cosmossdk.io/core from 1.0.0-alpha.5 to 1.0.0-alpha.6 (#22502)
  build(deps): Bump golang.org/x/crypto from 0.28.0 to 0.29.0 (#22480)
  docs(adr75): server v2 (#21069)
  fix(server/v2): improve server stop (#22455)
  chore: prepare core changelog (#22495)
  refactor(store/v2): simplify genesis flow (#22435)
  build(deps): Bump google.golang.org/grpc from 1.67.1 to 1.68.0 (#22486)
  build(deps): Bump golang.org/x/sync from 0.8.0 to 0.9.0 (#22482)
  feat(x/circuit): Allow msg Reset with empty msgURL (#22459)
  build(deps): Bump actions/xxx-artifact from v3 to v4 (#22468)
  feat(stf/branch): simplify merged iterator (#22131)
  refactor(log): disable coloring in testing logger (#22466)
  chore(x/tx): update changelog to alpha.2 (#22465)
  ...
@coderabbitai coderabbitai bot mentioned this pull request Nov 13, 2024
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski kocubinski is a code owner

@testinginprod testinginprod Awaiting requested review from testinginprod testinginprod is a code owner

@aaronc aaronc Awaiting requested review from aaronc aaronc is a code owner

Assignees

@aaronc aaronc

@kocubinski kocubinski

@testinginprod testinginprod

Labels
C:x/tx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JulianToledano @julienrbrt @tac0turtle @aaronc @kocubinski @testinginprod