refactor(log): disable coloring in testing logger #22466
Conversation
📝 WalkthroughWalkthroughThe pull request introduces updates primarily to the Go version used in the testing workflow and related files. The GitHub Actions workflow configuration in Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
julienrbrt
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/workflows/test.yml (1)
Based on the output, I can now generate the final response since I have verified the Go version requirements across all modules.
Go version inconsistencies should be standardized to Go 1.23.x
The codebase predominantly uses Go 1.23.x (specifically 1.23, 1.23.0, 1.23.1, or 1.23.2) across most modules. However, there are a few outliers:
- schema/testing: Go 1.12
- log: Go 1.21
- depinject: Go 1.20
These older versions should be updated to Go 1.23.x to maintain consistency and prevent potential compatibility issues across the codebase.
🔗 Analysis chain
Line range hint
1-1200: Consider standardizing Go versions across jobs.There are inconsistent Go versions being used across different jobs:
- Most jobs use Go 1.23
- Some jobs (depinject, errors, math) use Go 1.20
- The schema job uses Go 1.12
- The log job uses Go 1.21
This inconsistency could lead to compatibility issues. Consider standardizing the Go version across all jobs unless there's a specific requirement for different versions.
Let's verify the Go version requirements for each module:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check Go version requirements across all modules # Test: Search for go version in go.mod files echo "Checking go version in go.mod files..." fd -e mod -x cat {} \; | rg -A 1 "^go " # Test: Search for any version constraints in dependencies echo "Checking version constraints in dependencies..." fd -e mod -x cat {} \; | rg -A 5 "require"Length of output: 28917
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
📒 Files selected for processing (4)
.github/workflows/test.yml(1 hunks)log/CHANGELOG.md(1 hunks)log/go.mod(1 hunks)log/testing.go(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- log/go.mod
🧰 Additional context used
📓 Path-based instructions (2)
log/CHANGELOG.md (1)
Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
log/testing.go (1)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
🔇 Additional comments (5)
log/testing.go (2)
3-7: LGTM: Import changes are appropriate.
The addition of the time package import is necessary for the time.Kitchen constant, and the import block follows Go standards with proper grouping.
46-57: LGTM: Excellent improvements to logger configuration.
The changes effectively address the PR's objective by:
- Disabling colors through
NoColor: true - Using a more readable time format with
time.Kitchen - Maintaining the correct frame depth for accurate source locations
The implementation is clean and well-documented.
log/CHANGELOG.md (2)
25-25: LGTM: Version header follows the changelog format.
The version header correctly follows the link format and includes the release date.
27-29: LGTM: Changelog entries are well-formatted and informative.
The entries:
- Follow the required format:
[#<issue-number>] Changelog message - Are ordered from newest to oldest
- Provide clear, concise descriptions of changes
- Include the Go version requirement note for slog support
.github/workflows/test.yml (1)
858-858: LGTM: Go version update for the log job.
The update to Go 1.21 for the log job aligns with the changes in the log/go.mod file.
* main: (31 commits) docs: update links for https security protocol (#22514) build(deps): Bump github.com/bytedance/sonic from 1.12.3 to 1.12.4 in /log (#22513) feat(x/protocolpool)!: allow any coins in continuous funds (#21916) docs: Update protobuf tx signing message format outer link (#22510) test(accounts): fix integration tests (#22418) chore(x): fix some typos in comment (#22508) build(deps): Bump cosmossdk.io/log from 1.4.1 to 1.5.0 (#22487) build(deps): Bump cosmossdk.io/core from 1.0.0-alpha.5 to 1.0.0-alpha.6 (#22502) build(deps): Bump golang.org/x/crypto from 0.28.0 to 0.29.0 (#22480) docs(adr75): server v2 (#21069) fix(server/v2): improve server stop (#22455) chore: prepare core changelog (#22495) refactor(store/v2): simplify genesis flow (#22435) build(deps): Bump google.golang.org/grpc from 1.67.1 to 1.68.0 (#22486) build(deps): Bump golang.org/x/sync from 0.8.0 to 0.9.0 (#22482) feat(x/circuit): Allow msg Reset with empty msgURL (#22459) build(deps): Bump actions/xxx-artifact from v3 to v4 (#22468) feat(stf/branch): simplify merged iterator (#22131) refactor(log): disable coloring in testing logger (#22466) chore(x/tx): update changelog to alpha.2 (#22465) ...
Description
Got annoyed that the testing logger was unreadable within needing to tweak my terminal (or github ci terminal, which i'm not even sure is possible)
Disabling the color of the testing logger just makes more sense
(before)
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
Bug Fixes
Documentation