Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v0.33.x export script to port gov data correctly #4163

Merged
merged 3 commits into from
Apr 22, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Apr 21, 2019

Update the python export script to properly migrate governance state. This state machine breaking change was included in the 0.34 release but was not documented and as a result was not included in the original script.

Note: A node will not panic if this fix is not included, however, querying for past proposals will fail.


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added C:x/gov WIP C:genesis relating to chain genesis labels Apr 21, 2019
@codecov
Copy link

codecov bot commented Apr 21, 2019

Codecov Report

Merging #4163 into release/v0.34.1 will decrease coverage by 0.03%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           release/v0.34.1   #4163      +/-   ##
==================================================
- Coverage            60.04%     60%   -0.04%     
==================================================
  Files                  212     212              
  Lines                15127   15127              
==================================================
- Hits                  9083    9077       -6     
- Misses                5421    5427       +6     
  Partials               623     623

@jackzampolin jackzampolin merged commit b85371a into release/v0.34.1 Apr 22, 2019
@fedekunze fedekunze deleted the bez/gov-export-script-fix branch April 22, 2019 00:25
jackzampolin pushed a commit that referenced this pull request Apr 25, 2019
* Merge PR #4163: Fix v0.33.x export script to port gov data correctly

* Remove TOC

* Add missing changelog entry for v0.34.1

* Merge PR #4182: Cherry pick #4083 into v0.34.2

* Merge PR #4181: Cherry pick 4135 v0.34.2

* Merge PR #4183: Cherry pick 4181 into v0.34.2 

* Support pagination and status query params for /staking/validators

* Rename BondStatusToString to String

* Cherry pick 4181

* Remove pending log

* Fix CODEOWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:genesis relating to chain genesis C:x/gov
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants