Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick 4083 v0.34.2 #4182

Merged
merged 5 commits into from
Apr 24, 2019
Merged

Conversation

alexanderbez
Copy link
Contributor

This cherry picks #4083 already on develop to v0.34.2.


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #4182 into release/v0.34.2 will decrease coverage by <.01%.
The diff coverage is 57.14%.

@@                Coverage Diff                 @@
##           release/v0.34.2   #4182      +/-   ##
==================================================
- Coverage               60%     60%   -0.01%     
==================================================
  Files                  212     212              
  Lines                15127   15131       +4     
==================================================
+ Hits                  9077    9079       +2     
- Misses                5427    5429       +2     
  Partials               623     623

@jackzampolin jackzampolin merged commit c0e6b38 into release/v0.34.2 Apr 24, 2019
@jackzampolin jackzampolin deleted the cherry-pick-4083-v0.34.2 branch April 24, 2019 15:51
jackzampolin pushed a commit that referenced this pull request Apr 25, 2019
* Merge PR #4163: Fix v0.33.x export script to port gov data correctly

* Remove TOC

* Add missing changelog entry for v0.34.1

* Merge PR #4182: Cherry pick #4083 into v0.34.2

* Merge PR #4181: Cherry pick 4135 v0.34.2

* Merge PR #4183: Cherry pick 4181 into v0.34.2 

* Support pagination and status query params for /staking/validators

* Rename BondStatusToString to String

* Cherry pick 4181

* Remove pending log

* Fix CODEOWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants