Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: adopt keyring by default #5132

Closed
wants to merge 33 commits into from
Closed

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Oct 2, 2019

Breaking changes:

  • client/context/NewCLIContextWithFrom is gone
  • client/context/GetFromFields now takes an extra io.Reader
  • client/context/Context.WithFrom() now sets both FromName and FromAddress fields.

New client/Context's features:

  • An input buffer should be passed via WithInput()
  • WithKeybase() initialises a keybase/keybase according to flags or configuration
  • WithFromFields() calls WithFrom() and passes the contents of the --from flag as argument

keys commands use new keyring functionalities by default.
Use --legacy-keybase to switch back to the old keybase.


  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Breaking changes:
- client/context/NewCLIContextWithFrom is gone
- client/context/GetFromFields now takes an extra io.Reader
client/keys/utils.go Outdated Show resolved Hide resolved
client/keys/import.go Outdated Show resolved Hide resolved
client/keys/import.go Outdated Show resolved Hide resolved
client/keys/import.go Outdated Show resolved Hide resolved
@alessio alessio force-pushed the alessio/use-keyring-by-default branch from b8770dd to 5dda14d Compare October 6, 2019 23:19
@codecov
Copy link

codecov bot commented Oct 6, 2019

Codecov Report

Merging #5132 into master will decrease coverage by 0.09%.
The diff coverage is 34.22%.

@@            Coverage Diff            @@
##           master    #5132     +/-   ##
=========================================
- Coverage   54.96%   54.87%   -0.1%     
=========================================
  Files         297      297             
  Lines       18231    18283     +52     
=========================================
+ Hits        10021    10032     +11     
- Misses       7472     7523     +51     
+ Partials      738      728     -10

@alessio
Copy link
Contributor Author

alessio commented Oct 11, 2019

Superseded by #5180
Hence closing.

@alessio alessio closed this Oct 11, 2019
@fedekunze fedekunze deleted the alessio/use-keyring-by-default branch December 24, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants