Drop on-disk keybase in favor of keyring

[alessio]

Rationale for this work is articulated in https://github.com/cosmos/cosmos-sdk/blob/master/docs/architecture/adr-006-secret-store-replacement.md

Breaking changes:

• The following calls were removed from the client package and
  its subpackages:
  • GetKeyInfo()
  • GetPassphrase()
  • NewKeybaseFrom*()
  • ReadPassphraseFromStdin()
• GetFromFields() now takes a io.Reader as argument.
• NewTxBuilderFromCLI() constructor now takes a io.Reader, needed
  to initialise the user session's keyring.
• The keys update command is no longer used and shall be removed in
  a future release.
• server.GenerateSaveCoinKey() signature changed

CLIContext's new constructors are provided:

• NewCLIContextWithInputAndFrom()
• NewCLIContextWithInput()

CLIContext now encapsulates a io.Reader and provides a
WithInput(io.Reader) method to override the initial
configuration.

Thanks: @poldsam for the original patch #4754

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
• Wrote tests
• Updated relevant documentation (docs/)
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #5180 into master will decrease coverage by 0.01%.
The diff coverage is 36.25%.

@@            Coverage Diff             @@
##           master    #5180      +/-   ##
==========================================
- Coverage   54.72%   54.71%   -0.02%     
==========================================
  Files         307      307              
  Lines       18304    18290      -14     
==========================================
- Hits        10017    10007      -10     
- Misses       7501     7507       +6     
+ Partials      786      776      -10

[tnachen]

What does running on server mean here?

[alessio]

It's a misnomer, I copied it from the original PR and am happy to rename it. It attempts to determine whether the test is running on a developer machine or in a CI container.

[alessio]

This certainly breaks API and ABI. How comes that breaks the state machine too? @fedekunze

[fedekunze]

utACK

[fedekunze]

FYI, I'll merge this by EOD. I'll wait for more reviews until then

[tac0turtle]

bump merge me 😄

@fedekunze your days are quite long 😉

[fedekunze]

tested ACK

[andrecronje]

https://github.com/cosmos/cosmos-sdk/blame/c9370840bff5c363370d0ec0f95c482a05db5410/x/auth/client/utils/tx.go#L97

txBytes, err := txBldr.BuildAndSign(fromName, client.DefaultKeyPass, msgs)

BuildAndSign uses client.DefaultKeyPass instead of user input

[alessio]

@andrecronje BuildAndSign() could even pass an empty passphrase to Sign(), it wouldn't matter as it then calls MakeSignature() that in turn uses a Keybase interface instance to sign. If the keybase instance is a keyring-backed one, passphrase is discarded.

[alessio]

I've decided to keep the passphrase around even if it's empty in order to avoid the Keybase interface. Whether the passphrase is actually used depends on the keybase implementation used.