ADR 004 Geneis Migration #5589
Merged
ADR 004 Geneis Migration #5589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
commented
Jan 29, 2020
| @@ -46,15 +46,15 @@ type ( | |||
|
|
|||
| BaseAccount struct { | |||
| Address sdk.AccAddress `json:"address" yaml:"address"` | |||
| Coins sdk.Coins `json:"coins" yaml:"coins"` | |||
| Coins sdk.Coins `json:"coins,omitempty" yaml:"coins,omitempty"` | |||
There was a problem hiding this comment.
I've decided to add omitempty here to avoid having to literally copy the entire file solely to remove a single field.
alexanderbez
requested review from
alessio,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
fedekunze
approved these changes
Jan 29, 2020
| // it to v0.39 x/bank genesis state. The migration includes: | ||
| // | ||
| // - Moving balances from x/auth to x/bank genesis state. | ||
| func Migrate(bankGenState v038bank.GenesisState, authGenState v038auth.GenesisState) GenesisState { |
There was a problem hiding this comment.
Do we need to ensure that this Migrate runs before auth.Migrate? Is there anything that needs to be done to ensure that?
| "github.com/cosmos/cosmos-sdk/x/genutil" | ||
| ) | ||
|
|
||
| func Migrate(appState genutil.AppMap) genutil.AppMap { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part III (final) PR of #5572 -- genesis migration for ADR 004 slated for v0.39:
x/authgenesis state.x/bank.For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)