Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADR 004 Implementation #5572

Merged
merged 25 commits into from
Jan 30, 2020
Merged

ADR 004 Implementation #5572

merged 25 commits into from
Jan 30, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jan 27, 2020 •
edited
Loading

PR I of II. This PR covers the core and integral changes for the implementation of ADR 004 -- migrating account balance logic to the x/bank module.

To ease the review process, this PR does not cover updating unit tests and misc. tasks. A subsequent PR will be made to address unit tests and other loose ends.

TODO (in followup PRs):

closes: #5519
replaces: #5539

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added WIP T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). T: State Machine Breaking State machine breaking changes (impacts consensus). C:x/bank C:x/auth labels Jan 27, 2020
@alexanderbez alexanderbez added R4R and removed WIP labels Jan 27, 2020
@alexanderbez alexanderbez marked this pull request as ready for review January 27, 2020 16:41
This was referenced Jan 28, 2020
Merged
Merged
fedekunze
fedekunze approved these changes Jan 29, 2020
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, minor comments

x/bank/exported/exported.go Show resolved Hide resolved
x/bank/genesis.go Show resolved Hide resolved
x/bank/internal/keeper/invariants.go Show resolved Hide resolved
x/bank/internal/keeper/invariants.go Show resolved Hide resolved
cwgoes
cwgoes approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, but we should make sure to update the vesting account doc (we used to have one somewhere).

AdityaSripal
AdityaSripal requested changes Jan 30, 2020
View reviewed changes
Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @alexanderbez ! Left some comments

x/auth/vesting/types/vesting_account.go Outdated Show resolved Hide resolved
x/auth/vesting/types/vesting_account.go Outdated Show resolved Hide resolved
x/auth/vesting/types/vesting_account.go Outdated Show resolved Hide resolved
x/auth/vesting/types/vesting_account.go Show resolved Hide resolved
x/bank/internal/keeper/keeper.go Outdated Show resolved Hide resolved
x/bank/internal/keeper/keeper.go Outdated Show resolved Hide resolved
x/bank/internal/keeper/keeper.go Show resolved Hide resolved
x/bank/internal/types/genesis.go Show resolved Hide resolved
x/gov/simulation/operations.go Outdated Show resolved Hide resolved
AdityaSripal
AdityaSripal approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🎉

@alexanderbez alexanderbez merged commit 6890feb into master Jan 30, 2020
@alexanderbez alexanderbez deleted the bez/5519-adr-004-bank-balances branch January 30, 2020 21:31
@alexanderbez alexanderbez mentioned this pull request Feb 4, 2020
Merged
11 tasks
@alexanderbez alexanderbez mentioned this pull request Mar 12, 2021
Merged
9 tasks
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@alexanderbez
Merge PR cosmos#5572: ADR 004 Implementation
ae9af02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@jackzampolin jackzampolin jackzampolin approved these changes

@fedekunze fedekunze fedekunze approved these changes

@AdityaSripal AdityaSripal AdityaSripal approved these changes

@sunnya97 sunnya97 sunnya97 approved these changes

@alessio alessio Awaiting requested review from alessio

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
C:x/auth C:x/bank T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ADR 004 Implementation
6 participants
@alexanderbez @sunnya97 @jackzampolin @AdityaSripal @cwgoes @fedekunze