Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Account on SendCoins #5615

Merged
merged 3 commits into from
Feb 5, 2020
Merged

Create Account on SendCoins #5615

merged 3 commits into from
Feb 5, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Feb 4, 2020

With the merging of #5572, a regression occurred where when you send tokens to a new (non-existent account), the new account balance is created (in x/bank), but the actual account is not created in x/auth.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #5615 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5615      +/-   ##
==========================================
- Coverage   53.42%   53.42%   -0.01%     
==========================================
  Files         322      322              
  Lines       19745    19748       +3     
==========================================
+ Hits        10549    10550       +1     
- Misses       8379     8381       +2     
  Partials      817      817
Impacted Files Coverage Δ
x/bank/internal/keeper/keeper.go 84.73% <100%> (+0.18%) ⬆️
x/mock/app.go 65.24% <0%> (-1.22%) ⬇️

@alexanderbez alexanderbez merged commit 30d5f7d into master Feb 5, 2020
@alexanderbez alexanderbez deleted the bez/fix-bank-send-new-acc branch February 5, 2020 02:33
@@ -236,6 +236,15 @@ func (k BaseSendKeeper) SendCoins(ctx sdk.Context, fromAddr sdk.AccAddress, toAd
return err
}

// Create account if recipient does not exist.
//
// NOTE: This should ultimately be removed in favor a more flexible approach
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an issue for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunnya97 said he'd create an ADR for his "its on me" message idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants