-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Account on SendCoins #5615
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5615 +/- ##
==========================================
- Coverage 53.42% 53.42% -0.01%
==========================================
Files 322 322
Lines 19745 19748 +3
==========================================
+ Hits 10549 10550 +1
- Misses 8379 8381 +2
Partials 817 817
|
@@ -236,6 +236,15 @@ func (k BaseSendKeeper) SendCoins(ctx sdk.Context, fromAddr sdk.AccAddress, toAd | |||
return err | |||
} | |||
|
|||
// Create account if recipient does not exist. | |||
// | |||
// NOTE: This should ultimately be removed in favor a more flexible approach |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there an issue for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sunnya97 said he'd create an ADR for his "its on me" message idea.
With the merging of #5572, a regression occurred where when you send tokens to a new (non-existent account), the new account balance is created (in
x/bank
), but the actual account is not created inx/auth
.For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)