-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate upgrade module to protobuf #5659
Migrate upgrade module to protobuf #5659
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5659 +/- ##
==========================================
- Coverage 36.12% 35.46% -0.66%
==========================================
Files 330 331 +1
Lines 31976 32581 +605
==========================================
+ Hits 11550 11556 +6
- Misses 19203 19802 +599
Partials 1223 1223
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK -- Thank @aaronc! A few minor things:
- Use
appCodec
in simapp now. - Address changelog merge conflict
- Remove use of
internal/
pkg (just bump the directory up to the parent; ref: Remove Internal from Module Spec + Update Modules #5646)
b0d64cc
to
6cd1327
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 🌮 there are just a few minor linting/formatting issues.
@alexanderbez I think I took care of most of the issues. I'm a bit confused by a couple of golangcibot's recommendations for the CLI package as those imports do appear to be needed. |
Looks like there are a few minor formatting things. Will take a look. And something is weird with CircleCI proto. |
|
8556a0f
to
cedc60c
Compare
… update CHANGELOG
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
85f64db
to
6feb7ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Description
Migrates
x/upgrade
to support protobuf encoding.For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)