-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic sign mode infrastructure #6371
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6371 +/- ##
==========================================
+ Coverage 55.57% 55.61% +0.03%
==========================================
Files 452 454 +2
Lines 27322 27360 +38
==========================================
+ Hits 15185 15215 +30
- Misses 11046 11050 +4
- Partials 1091 1095 +4 |
aaronc
changed the title
Add SignModeHandler and LegacyAminoJSONHandler
Add basic sign mode infrastructure
Jun 8, 2020
aaronc
requested review from
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
June 8, 2020 23:37
aaronc
commented
Jun 8, 2020
fedekunze
approved these changes
Jun 9, 2020
alexanderbez
reviewed
Jun 9, 2020
Co-authored-by: Marko <marbar3778@yahoo.com>
alexanderbez
approved these changes
Jun 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of several bite-size PR's that are being pulled out of #6216 to implement #6213.
This PR adds:
SignModeHandler
andSigningData
typesLegacyAminoJSONHandler
as the first concreteSignModeHandler
implementationSignModeHandlerMap
which aggregates multiple handlers togetherThis PR does node add support for
SIGN_MODE_DIRECT
which will be added in a future PR.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer