Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic sign mode infrastructure #6371

Merged
merged 12 commits into from
Jun 9, 2020
Merged

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jun 8, 2020

This is one of several bite-size PR's that are being pulled out of #6216 to implement #6213.

This PR adds:

  • SignModeHandler and SigningData types
  • LegacyAminoJSONHandler as the first concrete SignModeHandler implementation
  • SignModeHandlerMap which aggregates multiple handlers together

This PR does node add support for SIGN_MODE_DIRECT which will be added in a future PR.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #6371 into master will increase coverage by 0.03%.
The diff coverage is 78.94%.

@@            Coverage Diff             @@
##           master    #6371      +/-   ##
==========================================
+ Coverage   55.57%   55.61%   +0.03%     
==========================================
  Files         452      454       +2     
  Lines       27322    27360      +38     
==========================================
+ Hits        15185    15215      +30     
- Misses      11046    11050       +4     
- Partials     1091     1095       +4     

@aaronc aaronc changed the title Add SignModeHandler and LegacyAminoJSONHandler Add basic sign mode infrastructure Jun 8, 2020
@aaronc aaronc marked this pull request as ready for review June 8, 2020 23:37
@aaronc aaronc added the R4R label Jun 8, 2020
x/auth/signing/amino/amino.go Outdated Show resolved Hide resolved
x/auth/signing/amino/amino.go Show resolved Hide resolved
x/auth/signing/handler_map.go Show resolved Hide resolved
x/auth/signing/sign_mode_handler.go Show resolved Hide resolved
Co-authored-by: Marko <marbar3778@yahoo.com>
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@aaronc aaronc added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 9, 2020
@mergify mergify bot merged commit 08b7557 into master Jun 9, 2020
@mergify mergify bot deleted the aaronc/6213-sign-mode-handler branch June 9, 2020 15:19
@clevinson clevinson added this to the v0.39 milestone Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants