-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SignatureV2 infrastructure #6373
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6373 +/- ##
==========================================
+ Coverage 55.66% 55.67% +0.01%
==========================================
Files 465 465
Lines 27674 27782 +108
==========================================
+ Hits 15404 15469 +65
- Misses 11169 11206 +37
- Partials 1101 1107 +6 |
aaronc
requested review from
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
June 9, 2020 19:58
aaronc
added
the
T: Proto Breaking
Protobuf breaking changes: never don't do this!
label
Jun 9, 2020
@fedekunze I addressed the comments, please take a look |
fedekunze
reviewed
Jun 11, 2020
aaronc
commented
Jun 11, 2020
fedekunze
approved these changes
Jun 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, minor comments
jgimeno
reviewed
Jun 12, 2020
…ronc/6213-sig-v2
jgimeno
reviewed
Jun 12, 2020
jgimeno
approved these changes
Jun 12, 2020
This was referenced Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A:automerge
Automatically merge PR once all prerequisites pass.
T: Proto Breaking
Protobuf breaking changes: never don't do this!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of several bite-size PR's that are being pulled out of #6216 to implement #6213.
Summary
This PR adds the basic application logic types for dealing with multiple signing modes as well as multi-signatures in a backwards compatible and hopefully convenient way. The top-level new types here are
SignatureV2
to be used for both signing and verifying and themultisig.PubKey
interface.Details
SignMode
was moved into a separate package (types/tx/signing
) because of cyclic dependency issuesSignatureV2
andSingle|MultiSignatureData
types were addedmultisig.PubKey
interface was added which usesMultiSignatureData
for verificationmultisig.Multisignature
was renamed toAminoMultisignature
and convenience functions for converting between aminoStdSignature
/AminoMultisignature
and newSignatureV2
/SignatureData
types were addedmultisig.AddSignature*
functions now useMultiSignatureData
instead ofAminoMultisignature
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer