Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate remaining x/auth tx tests to proto #6898

Merged
merged 7 commits into from
Jul 30, 2020
Merged

Conversation

sahith-narahari
Copy link
Contributor

@sahith-narahari sahith-narahari commented Jul 30, 2020

ref: #6213. Migrates cases that were missed in #6717.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #6898 into master will increase coverage by 2.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6898      +/-   ##
==========================================
+ Coverage   58.29%   60.76%   +2.46%     
==========================================
  Files         361      381      +20     
  Lines       21453    24870    +3417     
==========================================
+ Hits        12507    15112    +2605     
- Misses       7946     8603     +657     
- Partials     1000     1155     +155     

@aaronc aaronc changed the title Fix x/auth proto tests Migrate remaining x/auth tx tests to proto Jul 30, 2020
@aaronc aaronc marked this pull request as ready for review July 30, 2020 14:54
@aaronc aaronc added A:automerge Automatically merge PR once all prerequisites pass. C:x/auth labels Jul 30, 2020
@mergify mergify bot merged commit e15d032 into master Jul 30, 2020
@mergify mergify bot deleted the sahith/fix-auth-proto branch July 30, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants