Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: tm v0.34.2 #8318

Closed
wants to merge 2 commits into from
Closed

backport: tm v0.34.2 #8318

wants to merge 2 commits into from

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Jan 12, 2021 •
edited by amaury1093
Loading

Description

backport #8316

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@fedekunze fedekunze changed the base branch from master to release/v0.40.x January 12, 2021 20:28
@fedekunze fedekunze marked this pull request as ready for review January 12, 2021 20:28
@fedekunze fedekunze added backport/0.40.x (Stargate) dependencies Pull requests that update a dependency file C: comet labels Jan 12, 2021
@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Jan 12, 2021
@aaronc
Copy link
Member

aaronc commented Jan 13, 2021

Does this deserve its own point release?

@alessio
Copy link
Contributor

alessio commented Jan 13, 2021

@aaronc we are about to merge the Rosetta API implementation. Maybe we can release both changes together as 0.40.1?

@aaronc
Copy link
Member

aaronc commented Jan 13, 2021

@aaronc we are about to merge the Rosetta API implementation. Maybe we can release both changes together as 0.40.1?

Sure

@amaury1093 amaury1093 mentioned this pull request Jan 19, 2021
Closed
22 tasks
@amaury1093 amaury1093 added this to the v0.40.1 milestone Jan 19, 2021
@fdymylja fdymylja self-requested a review January 19, 2021 14:32
@amaury1093
Copy link
Contributor

superseded by #8387

@amaury1093 amaury1093 closed this Jan 19, 2021
@alessio alessio removed this from the v0.40.1 milestone Jan 19, 2021
@alessio alessio deleted the fedekunze/backport-tm branch March 14, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio alessio alessio approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@jgimeno jgimeno jgimeno approved these changes

@fdymylja fdymylja fdymylja approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C: comet dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fedekunze @aaronc @alessio @amaury1093 @jgimeno @fdymylja