Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump tendermint to v0.34.3 #8387

Closed
wants to merge 3 commits into from
Closed

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jan 19, 2021


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Do you want to put the changelog here, or in the final 0.40.1 changelog PR?

This was referenced Jan 19, 2021
@amaury1093 amaury1093 mentioned this pull request Jan 19, 2021
9 tasks
@@ -42,15 +42,15 @@ require (
github.com/spf13/jwalterweatherman v1.1.0 // indirect; indirects
github.com/spf13/pflag v1.0.5
github.com/spf13/viper v1.7.1
github.com/stretchr/testify v1.6.1
github.com/stretchr/testify v1.7.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why, but go mod tidy updates the version for me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll redo the PR as last bit of the release

@alessio alessio removed this from the v0.40.1 milestone Jan 19, 2021
@alessio
Copy link
Contributor Author

alessio commented Jan 19, 2021

Will redo shortly

@alessio alessio closed this Jan 19, 2021
@alessio alessio deleted the alessio-v0.40.1-tm0343 branch January 19, 2021 16:04
@amaury1093 amaury1093 mentioned this pull request Jan 19, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants