Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Dec.Float64() function #9382

Merged
merged 9 commits into from
May 26, 2021
Merged

feat: add Dec.Float64() function #9382

merged 9 commits into from
May 26, 2021

Conversation

freak12techno
Copy link
Contributor

@freak12techno freak12techno commented May 21, 2021

Description

closes: #9379


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/) (there are no docs for similar functions, so I'm not sure if this is needed)
  • Added relevant godoc comments. (this function is kinda obvious, is it required?)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

types/decimal.go Show resolved Hide resolved
@freak12techno
Copy link
Contributor Author

@alexanderbez it seems like I need a maintainer approve for this to be merged(as I'm the first-time contributor), otherwise CI checks won't run. Do you know who else should approve it for this to be ready to merge?

types/decimal.go Outdated Show resolved Hide resolved
types/decimal.go Outdated Show resolved Hide resolved
freak12techno and others added 3 commits May 25, 2021 12:41
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #9382 (d120bb2) into master (8c1fe4b) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

❗ Current head d120bb2 differs from pull request most recent head 5da5c75. Consider uploading reports for the commit 5da5c75 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9382      +/-   ##
==========================================
- Coverage   60.40%   60.40%   -0.01%     
==========================================
  Files         589      589              
  Lines       37095    37100       +5     
==========================================
+ Hits        22407    22410       +3     
- Misses      12711    12712       +1     
- Partials     1977     1978       +1     
Impacted Files Coverage Δ
types/decimal.go 70.12% <60.00%> (-0.17%) ⬇️

@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label May 25, 2021
@freak12techno
Copy link
Contributor Author

@alexanderbez how does the automerge work here? Seems like it doesn't like 3 failed PR checks or maybe something more.

@mergify mergify bot merged commit 9536ba7 into cosmos:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"github.com/cosmos/cosmos-sdk/types".Dec does not provide an easy way to get data as float
4 participants