-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Dec.Float64() function #9382
Conversation
@alexanderbez it seems like I need a maintainer approve for this to be merged(as I'm the first-time contributor), otherwise CI checks won't run. Do you know who else should approve it for this to be ready to merge? |
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## master #9382 +/- ##
==========================================
- Coverage 60.40% 60.40% -0.01%
==========================================
Files 589 589
Lines 37095 37100 +5
==========================================
+ Hits 22407 22410 +3
- Misses 12711 12712 +1
- Partials 1977 1978 +1
|
@alexanderbez how does the automerge work here? Seems like it doesn't like 3 failed PR checks or maybe something more. |
Description
closes: #9379
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
) (there are no docs for similar functions, so I'm not sure if this is needed)godoc
comments. (this function is kinda obvious, is it required?)Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes