Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Dec.Float64() function #9382

Merged
merged 9 commits into from
May 26, 2021
Merged

feat: add Dec.Float64() function #9382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a8aabd6
feat: add Dec.Float64() function
freak12techno May 21, 2021
b6f636c
chore: add CHANGELOG.md release entry
freak12techno May 21, 2021
b3c84d8
chore: added MustFloat64(), return result with error on Float64()
freak12techno May 23, 2021
fdd99a0
chore: add godoc
freak12techno May 23, 2021
aa080ba
Update types/decimal.go
freak12techno May 25, 2021
fcce66f
Update types/decimal.go
freak12techno May 25, 2021
d120bb2
Merge branch 'master' into add-float64-to-int
freak12techno May 25, 2021
abd6514
chore: re-ordered changelog
freak12techno May 25, 2021
5da5c75
Merge branch 'master' into add-float64-to-int
amaury1093 May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ if input key is empty, or input data contains empty key.
* [#9088](https://github.com/cosmos/cosmos-sdk/pull/9088) Added implementation to ADR-28 Derived Addresses.
* [\#9133](https://github.com/cosmos/cosmos-sdk/pull/9133) Added hooks for governance actions.
* (x/staking) [\#9214](https://github.com/cosmos/cosmos-sdk/pull/9214) Added `new_shares` attribute inside `EventTypeDelegate` event.
* [\#9382](https://github.com/cosmos/cosmos-sdk/pull/9382) feat: add Dec.Float64() function.

### Client Breaking Changes

Expand Down
16 changes: 16 additions & 0 deletions types/decimal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,22 @@ func (d Dec) String() string {
return string(bzStr)
}

// Float64 returns the float64 representation of a Dec.
// Will return the error if the conversion failed.
func (d Dec) Float64() (float64, error) {
alexanderbez marked this conversation as resolved.
Show resolved Hide resolved
return strconv.ParseFloat(d.String(), 64)
}

// MustFloat64 returns the float64 representation of a Dec.
// Would panic if the conversion failed.
func (d Dec) MustFloat64() float64 {
if value, err := strconv.ParseFloat(d.String(), 64); err != nil {
panic(err)
alexanderbez marked this conversation as resolved.
Show resolved Hide resolved
} else {
return value
}
}

// ____
// __| |__ "chop 'em
// ` \ round!"
Expand Down
22 changes: 22 additions & 0 deletions types/decimal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,28 @@ func (s *decimalTestSuite) TestDecString() {
}
}

func (s *decimalTestSuite) TestDecFloat64() {
tests := []struct {
d sdk.Dec
want float64
}{
{sdk.NewDec(0), 0.000000000000000000},
{sdk.NewDec(1), 1.000000000000000000},
{sdk.NewDec(10), 10.000000000000000000},
{sdk.NewDec(12340), 12340.000000000000000000},
{sdk.NewDecWithPrec(12340, 4), 1.234000000000000000},
{sdk.NewDecWithPrec(12340, 5), 0.123400000000000000},
{sdk.NewDecWithPrec(12340, 8), 0.000123400000000000},
{sdk.NewDecWithPrec(1009009009009009009, 17), 10.090090090090090090},
}
for tcIndex, tc := range tests {
value, err := tc.d.Float64()
s.Require().Nil(err, "error getting Float64(), index: %v", tcIndex)
s.Require().Equal(tc.want, value, "bad Float64(), index: %v", tcIndex)
s.Require().Equal(tc.want, tc.d.MustFloat64(), "bad MustFloat64(), index: %v", tcIndex)
}
}

func (s *decimalTestSuite) TestEqualities() {
tests := []struct {
d1, d2 sdk.Dec
Expand Down