Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: x/staking inplace store migration bug #9484

Merged
merged 4 commits into from
Jun 10, 2021

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Jun 9, 2021

Description

We are testing in place store migration using v0.43.0-beta1. Chain upgrade failed with the following error message panic: SetKeyTable() called on already initialized subspace.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

successfully tested an upgrade with this here

@clevinson clevinson added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 10, 2021
@clevinson clevinson added this to the v0.43 milestone Jun 10, 2021
@mergify mergify bot merged commit 606bb2f into master Jun 10, 2021
@mergify mergify bot deleted the aleem/test-0.43-beta-upgrade branch June 10, 2021 15:23
@amaury1093 amaury1093 mentioned this pull request May 24, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/staking T: Migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants