-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop on-disk keybase in favor of keyring #164
Conversation
This reverts commit c299dd9.
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
==========================================
+ Coverage 65.72% 66.46% +0.74%
==========================================
Files 5 5
Lines 493 492 -1
==========================================
+ Hits 324 327 +3
+ Misses 138 134 -4
Partials 31 31 |
This is ready for preliminary review, although it should not be merged til cosmos/cosmos-sdk#5180 is merged first |
@alessio is this R4R? |
Yes @fedekunze, it is de facto R4R. I didn't tag it yet as such 'cause I was waiting for the SDK's respective PR to be merged first. EDIT: I actually tagged it, @alexanderbez rightly removed the tag because it was blocked on the SDK's PR. But please feel free to review it, it's in fact ready and should be used to test the new keyring integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, I have some questions only. Once those are replied/addressed I'll merge the implementation on the SDK
FYI I've carried out some code clean up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested ACK. @alessio mind updating this branch to latest SDK master?
Will update tests ASAP |
All sorted @fedekunze |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. Thanks @alessio. We’ll probably have to write down the key migration guides for the next major release (cosmoshub-4) wiki and more docs for each OS.
This changeset aims to adapt
gaia
to the changes introduced incosmos/cosmos-sdk#5180
Rationale for this work is articulated in
docs/
)Unreleased
section inCHANGELOG.md
Files changed
in the github PR explorerFor Admin Use: