Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e tests for param changes for ics20 #2014

Closed
3 tasks
colin-axner opened this issue Aug 16, 2022 · 0 comments · Fixed by #2071
Closed
3 tasks

Add e2e tests for param changes for ics20 #2014

colin-axner opened this issue Aug 16, 2022 · 0 comments · Fixed by #2071
Assignees
@colin-axner
Labels
e2e
Milestone
v5.0.0

Comments

@colin-axner
Copy link
Contributor

Summary

Add e2e tests for performing param changes on our ibc apps

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega crodriguezvega added this to the v5.0.0 milestone Aug 19, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Aug 19, 2022
@colin-axner colin-axner self-assigned this Aug 22, 2022
@colin-axner colin-axner mentioned this issue Aug 22, 2022
Merged
9 tasks
@colin-axner colin-axner changed the title Add e2e tests for param changes Add e2e tests for param changes for ics20 Aug 22, 2022
This was referenced Aug 22, 2022
Closed
Merged
Merged
@colin-axner colin-axner moved this from Todo to In review in ibc-go Aug 25, 2022
mergify bot pushed a commit that referenced this issue Aug 25, 2022
@colin-axner
add e2e for transfer send enabled param (#2123)
915d974 
## Description

```
make e2e-test suite=TransferTestSuite test=TestSendEnabledParam
```

ref: #2014 

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [ ] Re-reviewed `Files changed` in the Github PR explorer
- [ ] Review `Codecov Report` in the comment section below once CI passes
Repository owner moved this from In review to Done in ibc-go Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
e2e
Projects
ibc-go
Archived in project
Milestone
v5.0.0
Development

Successfully merging a pull request may close this issue.

e2e: transfer receive enabled param test cosmos/ibc-go
2 participants
@crodriguezvega @colin-axner