Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add e2e for transfer send enabled param #2123

Merged
merged 5 commits into from
Aug 25, 2022
Merged

add e2e for transfer send enabled param #2123

merged 5 commits into from
Aug 25, 2022

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Aug 25, 2022 •
edited
Loading

Description

make e2e-test suite=TransferTestSuite test=TestSendEnabledParam

ref: #2014

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@colin-axner colin-axner marked this pull request as ready for review August 25, 2022 13:09
chatton
chatton approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work really concise test, love it!

e2e/transfer_test.go Outdated Show resolved Hide resolved
@colin-axner @chatton
Update e2e/transfer_test.go
2542e0f 
Co-authored-by: Cian Hatton <cian@interchain.io>
@chatton chatton mentioned this pull request Aug 25, 2022
Merged
23 tasks
damiannolan
damiannolan approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mergify mergify bot merged commit 915d974 into main Aug 25, 2022
@mergify mergify bot deleted the colin/2014-sendenabled-test branch August 25, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chatton chatton chatton approved these changes

@damiannolan damiannolan damiannolan approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@seantking seantking Awaiting requested review from seantking

@charleenfei charleenfei Awaiting requested review from charleenfei

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colin-axner @damiannolan @chatton