Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement ics-721-nft-transfer #1510

Conversation

dreamer-zq
Copy link

Description

closes: #1444


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@dreamer-zq dreamer-zq changed the title implement ics-721-nft-transfer WIP: implement ics-721-nft-transfer Jun 8, 2022
@dreamer-zq dreamer-zq mentioned this pull request Jun 8, 2022
3 tasks
@faddat faddat mentioned this pull request Jun 11, 2022
@dreamer-zq dreamer-zq changed the title WIP: implement ics-721-nft-transfer feat: implement ics-721-nft-transfer Jul 4, 2022
@faddat faddat mentioned this pull request Jul 16, 2022
9 tasks
@faddat
Copy link
Contributor

faddat commented Jul 16, 2022

@dreamer-zq

Hey, I am going to merge this into the branch shown here

I think this is awesome work and definitely want to get it in. I also think that the former notion for 46, is no more. So let's pray this doesn't explode too much when I attempt the merge.

On second thought, due to explosions, I will make a temp branch that targets #1653 get that solid, then merge it to #1653.

Thanks so much for the NFT support I know many projects are keen for it!

On third thought, I see that I'll need to get this migrated to tendermint 34 ... so, what I am actually going to do is make a PR from #1653 into your repo.

@faddat
Copy link
Contributor

faddat commented Jul 16, 2022

@dreamer-zq
Copy link
Author

@dreamer-zq

Hey, I am going to merge this into the branch shown here

I think this is awesome work and definitely want to get it in. I also think that the former notion for 46, is no more. So let's pray this doesn't explode too much when I attempt the merge.

On second thought, due to explosions, I will make a temp branch that targets #1653 get that solid, then merge it to #1653.

Thanks so much for the NFT support I know many projects are keen for it!

On third thought, I see that I'll need to get this migrated to tendermint 34 ... so, what I am actually going to do is make a PR from #1653 into your repo.

OK, do you need to merge now ?

@faddat
Copy link
Contributor

faddat commented Jul 19, 2022

Actually it may be a good idea to leave this stable until v5 is a little more concrete.

@faddat faddat mentioned this pull request Jul 21, 2022
9 tasks
@crodriguezvega
Copy link
Contributor

Closing this now since the ICS721 NFT application is living right now in its own repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants