-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement ics-721-nft-transfer #1510
feat: implement ics-721-nft-transfer #1510
Conversation
…hub.com/cosmos/ibc-go into ics-721-nft-transfer
Hey, I am going to merge this into the branch shown here I think this is awesome work and definitely want to get it in. I also think that the former notion for 46, is no more. So let's pray this doesn't explode too much when I attempt the merge. On second thought, due to explosions, I will make a temp branch that targets #1653 get that solid, then merge it to #1653. Thanks so much for the NFT support I know many projects are keen for it! On third thought, I see that I'll need to get this migrated to tendermint 34 ... so, what I am actually going to do is make a PR from #1653 into your repo. |
OK, do you need to merge now ? |
Actually it may be a good idea to leave this stable until v5 is a little more concrete. |
Closing this now since the ICS721 NFT application is living right now in its own repository. |
Description
closes: #1444
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes