Nftc

[vuong177]

No description provided.

[faddat]

Voung, could you give us some context on this one?

We are going to need to do a ton of rework on craft beacuase of the middleware issues, please see #114

[vuong177]

Voung, could you give us some context on this one?

We are going to need to do a ton of rework on craft beacuase of the middleware issues, please see #114

yes, i'm going to make descript.
This PR is module-approach for craft-nft. I trying to reuse sdk-nft code and compleet it. It save so much time than use cosmwasm nft.

[faddat]

Does this code depend on the middleware stuff?

[vuong177]

Does this code depend on the middleware stuff?

No, I've read code.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
253 Code Smells

No Coverage information
37.2% Duplication

[faddat]

Hey Vuong, I think it's likely much better to use the sdk's nft module, because of this:

cosmos/ibc-go#1510

After speaking with sistla, @Reecepbcups and the stargaze team, that seems best path forward. But I may have misunderstood the intent of this PR, so if I got it wrong, please let me know OK?

[vuong177]

@faddat, our NFT has some particular logic in mint, list NFT. I have discussed this with @Reecepbcups in #101. It's why I chose to build the NFTc module instead of the SDK module.

[vuong177]

Hey Vuong, I think it's likely much better to use the sdk's nft module, because of this:

cosmos/ibc-go#1510

After speaking with sistla, @Reecepbcups and the stargaze team, that seems best path forward. But I may have misunderstood the intent of this PR, so if I got it wrong, please let me know OK?

I'm reading this PR to make sure our module can be enabled ICS721 or not.

[Reecepbcups]

@faddat, our NFT has some particular logic in mint, list NFT. I have discussed this with @Reecepbcups in #101. It's why I chose to build the NFTc module instead of the SDK module.

Just FYI, I can use any NFT platform I think so long as it has attributes (JSON object encoded to string).
I'm building off oNFT and using it atm to test against and it goes well.

Here is an example mint I did
https://rest.flixnet-4.omniflix.network/omniflix/onft/v1beta1/onfts/onftdenom23c8ecb9a9e2484ebfc7c4847e65f15b/omniflix13na285c3llhnfenq6hl3fh255scljcue4td9nh

Then I wrote a REST api for it to be easily queried from chain for my needs from the oNFT data section

• https://api.crafteconomy.io/v1/realestate/owned/omniflix13na285c3llhnfenq6hl3fh255scljcue4td9nh

[vuong177]

@faddat I'm going to use SDK module and close this PR.

[faddat]

ok. @vuong177 keep the code around in its branch please. Thanks!

[sascha1337]

how far is the cosmos/ibc-go#1510 ICS721 to be used in production?