Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding sdk.Msg impl for ics27 MsgRegisterAccount (backport #2081) #2108

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 24, 2022

This is an automatic backport of pull request #2081 done by Mergify.
Cherry-pick of 94d0840 has failed:

On branch mergify/bp/release/v5.1.x/pr-2081
Your branch is up to date with 'origin/release/v5.1.x'.

You are currently cherry-picking commit 94d0840.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   modules/apps/27-interchain-accounts/controller/types/msgs_test.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   modules/apps/27-interchain-accounts/controller/types/msgs.go
	both modified:   testing/values.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* adding new controller msg service, register account types, register interfaces and boilerplate

* fixing typo

* fixing protodoc and regenerate godocs

* adding channel id to MsgRegisterAccountResponse

* adding sdk.Msg impl for MsgRegisterAccount

* formatting imports

* adding additional tests with multiple versions, creating TestAccAddress const

(cherry picked from commit 94d0840)

# Conflicts:
#	modules/apps/27-interchain-accounts/controller/types/msgs.go
#	testing/values.go
@damiannolan
Copy link
Member

I can handle the conflicts on this. Also looks like it requires #2051 to be backported first

@damiannolan damiannolan enabled auto-merge (squash) August 25, 2022 10:48
@damiannolan damiannolan merged commit 0f31a6e into release/v5.1.x Aug 25, 2022
@damiannolan damiannolan deleted the mergify/bp/release/v5.1.x/pr-2081 branch August 25, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants