Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename client update param messages to match other modules. #3708

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

DimitrisJim
Copy link
Contributor

Description

Reference #3650 (comment)

closes: #XXXX

Commit Message / Changelog Entry

nit: rename client update param messages to match other modules.

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@codecov-commenter
Copy link

Codecov Report

Merging #3708 (241b58e) into main (83e6877) will not change coverage.
The diff coverage is 85.71%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3708   +/-   ##
=======================================
  Coverage   78.74%   78.74%           
=======================================
  Files         186      186           
  Lines       12816    12816           
=======================================
  Hits        10092    10092           
  Misses       2291     2291           
  Partials      433      433           
Impacted Files Coverage Δ
modules/core/02-client/types/msgs.go 75.00% <75.00%> (ø)
modules/core/02-client/types/codec.go 79.79% <100.00%> (ø)
modules/core/keeper/msg_server.go 55.24% <100.00%> (ø)

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @DimitrisJim 💚

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@DimitrisJim DimitrisJim enabled auto-merge (squash) June 1, 2023 08:11
@DimitrisJim DimitrisJim merged commit 14c2698 into main Jun 1, 2023
@DimitrisJim DimitrisJim deleted the jim/rename-client-params-messages branch June 1, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants