Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename portid and port prefix for interchain accounts submodules (backport #779) #826

Merged
merged 1 commit into from
Feb 2, 2022

Commits on Feb 2, 2022

  1. rename portid and port prefix for interchain accounts submodules (#779)

    ## Description
    
    I decided to remove the `-` from the port ID (`ica-host`) and prefix (`ica-controller`) and just make it one word (`icahost` and `icacontroller`), just in case we decide to do some parsing based on a `-` delimiter in the future.
    
    closes: #778
    
    ---
    
    Before we can merge this PR, please make sure that all the following items have been
    checked off. If any of the checklist items are not applicable, please leave them but
    write a little note why.
    
    - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
    - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
    - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
    - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
    - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
    - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
    - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
    - [ ] Re-reviewed `Files changed` in the Github PR explorer
    - [ ] Review `Codecov Report` in the comment section below once CI passes
    
    (cherry picked from commit 8cba0eb)
    crodriguezvega authored and mergify-bot committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    f3149e6 View commit details
    Browse the repository at this point in the history