CBG-3844 Ensure sequence update waits for callback invocation (#6773)

couchbase · Apr 16, 2024 · 20c48f5 · 20c48f5
1 parent cc41244
commit 20c48f5
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/base/dcp_common.go b/base/dcp_common.go
@@ -96,8 +96,8 @@ func NewDCPCommon(ctx context.Context, callback sgbucket.FeedEventCallbackFunc,
 }
 
 func (c *DCPCommon) dataUpdate(seq uint64, event sgbucket.FeedEvent) {
-	c.updateSeq(event.VbNo, seq, true)
 	shouldPersistCheckpoint := c.callback(event)
+	c.updateSeq(event.VbNo, seq, true)
 	if c.persistCheckpoints && shouldPersistCheckpoint {
 		c.incrementCheckpointCount(event.VbNo)
 	}