CBG-3844 Ensure sequence update waits for callback invocation #6773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During rebalance, DCP metadata may be updated independent of SGW's checkpointing. To account for this, need to ensure last seq isn't updated until callback is invoked.
|
Failing integration test passes locally and appears unrelated, filed https://issues.couchbase.com/browse/CBG-3890. |
torcolvin
approved these changes
Apr 16, 2024
bbrks
pushed a commit
that referenced
this pull request
May 1, 2024
bbrks
pushed a commit
that referenced
this pull request
May 1, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During rebalance, DCP metadata may be updated independent of SGW's checkpointing. To account for this, need to ensure last seq isn't updated until callback is invoked.
CBG-3844
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2831/