Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speed up db/indextest by 5 minutes #6911

Merged
merged 2 commits into from
Sep 23, 2024
Merged

speed up db/indextest by 5 minutes #6911

merged 2 commits into from
Sep 23, 2024

Conversation

torcolvin
Copy link
Collaborator

  • create TestBucketPoolEnsureNoIndexes to do:
    • dcp purge deletion instead of flush
    • all index deletion
    • no primary index creation
  • shorten the number of test that need to recreate indexes in index tests
    • parametrize QueryAllRoles/QueryRoles inside existing case
    • put ExplainQuery tests as subtests of existing test, so we don't create indexes just to test covered query
    • put includeDeleted subtest inside database creation
  • reduce number of collections to create indexes, to be faster and more realistic about what indexes are actually created
    • create metadata only indexes in default data store, and only non metadata indexes in named datastore
    • create indexes in a single named collection, instead of all (3) collections

@torcolvin
speed up db/indextest by 5 minutes
b3b2716 
- create TestBucketPoolEnsureNoIndexes to do:
    - dcp purge deletion instead of flush
    - all index deletion
- shorten the number of test that need to recreate indexes in index
  tests
    - parametrize QueryAllRoles/QueryRoles inside existing case
    - put ExplainQuery tests as subtests of existing test, so we don't create
      indexes just to test covered query
    - put includeDeleted subtest inside database creation
@torcolvin torcolvin mentioned this pull request Jun 24, 2024
Merged
1 task
@torcolvin torcolvin requested a review from bbrks September 23, 2024 13:17
@bbrks bbrks merged commit ea6ba6d into main Sep 23, 2024
21 checks passed
@bbrks bbrks deleted the speed-up-indextest branch September 23, 2024 13:41
bbrks pushed a commit that referenced this pull request Oct 22, 2024
@torcolvin @bbrks
speed up db/indextest by 5 minutes (#6911)
8e93412 
- create TestBucketPoolEnsureNoIndexes to do:
    - dcp purge deletion instead of flush
    - all index deletion
- shorten the number of test that need to recreate indexes in index
  tests
    - parametrize QueryAllRoles/QueryRoles inside existing case
    - put ExplainQuery tests as subtests of existing test, so we don't create
      indexes just to test covered query
    - put includeDeleted subtest inside database creation
@bbrks bbrks mentioned this pull request Oct 22, 2024
Merged
1 task
torcolvin added a commit that referenced this pull request Oct 22, 2024
@torcolvin
speed up db/indextest by 5 minutes (#6911)
e16f3dd 
- create TestBucketPoolEnsureNoIndexes to do:
    - dcp purge deletion instead of flush
    - all index deletion
- shorten the number of test that need to recreate indexes in index
  tests
    - parametrize QueryAllRoles/QueryRoles inside existing case
    - put ExplainQuery tests as subtests of existing test, so we don't create
      indexes just to test covered query
    - put includeDeleted subtest inside database creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbrks bbrks bbrks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torcolvin @bbrks