Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.2.1 Backport] CBG-4150: Collection index creation improvements #7169

Merged
merged 4 commits into from
Oct 22, 2024
Merged

[3.2.1 Backport] CBG-4150: Collection index creation improvements #7169

merged 4 commits into from
Oct 22, 2024

Conversation

bbrks
Copy link
Member

@bbrks bbrks commented Oct 22, 2024 •
edited
Loading

@bbrks bbrks requested a review from torcolvin October 22, 2024 16:23
@torcolvin torcolvin enabled auto-merge (squash) October 22, 2024 19:36
@torcolvin torcolvin disabled auto-merge October 22, 2024 19:38
@torcolvin torcolvin enabled auto-merge (squash) October 22, 2024 19:39
@torcolvin torcolvin disabled auto-merge October 22, 2024 19:41
@torcolvin torcolvin enabled auto-merge (squash) October 22, 2024 19:42
torcolvin and others added 4 commits October 22, 2024 15:44
@torcolvin
speed up db/indextest by 5 minutes (#6911)
e16f3dd 
- create TestBucketPoolEnsureNoIndexes to do:
    - dcp purge deletion instead of flush
    - all index deletion
- shorten the number of test that need to recreate indexes in index
  tests
    - parametrize QueryAllRoles/QueryRoles inside existing case
    - put ExplainQuery tests as subtests of existing test, so we don't create
      indexes just to test covered query
    - put includeDeleted subtest inside database creation
@bbrks @torcolvin
CBG-4241: Low risk refactoring in _getOrAddDatabaseFromConfig (#7115)
a4cdfab 
* Rename WaitUntilDataStoreExists to WaitUntilDataStoreReady

* Move Unsupported.WarningThresholds init code into dbcOptionsFromConfig function already doing similar work

* Unnest if return ... else return

* Outdent return ... else ... block

* else ... if -> else if

* Build ScopeAndCollectionName and DataStore only once in loops

* Push DataStore Get and Wait until ready down into function

* Earlier db name validation
@bbrks @torcolvin
CBG-3026: Use DatabaseInitManager in all GSI cases (#7121)
0772bfe
@bbrks @torcolvin
CBG-2838: Rely on index 'IF NOT EXISTS' and idempotent deferred index…
ecfaeaa 
… builds fo… (#7161)
@torcolvin torcolvin merged commit c1d99bd into release/3.2.1 Oct 22, 2024
38 of 40 checks passed
@torcolvin torcolvin deleted the CBG-4150 branch October 22, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torcolvin torcolvin torcolvin approved these changes

Assignees

@torcolvin torcolvin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbrks @torcolvin