CBG-4417 construct missing CV entry from HLV if not present #7242
+90
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
adamcfraser
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a concept of an implicit HLV. This address a problem of replication that have Couchbase Server without Sync Gateway. If a past write contained an
_vventry, and then an update was performed on that same document, the_vvon the Couchbase Server only node is out of date - the implicit HLV needs to add the current cas@sourceID.Previously, the code only worked if there were no pv entries.
This isn't implemented for Couchbase Lite because there's no concept of document storage, so we do not necessarily have a concept of merged local and remote pv. In order to fix this, it will involve modifying BlipTester code which I do not want to do in this PR.