Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove race condition between different evaluation periods by deleting Parameters parameter from evaluateMeasure(). #556

Conversation

lukedegruchy
Copy link
Contributor

No description provided.

…g Parameters parameter from evaluateMeasure().
@lukedegruchy lukedegruchy marked this pull request as ready for review October 10, 2024 17:47
Copy link

github-actions bot commented Oct 10, 2024

Formatting check succeeded!

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.07%. Comparing base (6a2cfb0) to head (1a032f4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../fhir/cr/measure/common/BaseMeasureEvaluation.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #556      +/-   ##
============================================
+ Coverage     73.06%   73.07%   +0.01%     
  Complexity       19       19              
============================================
  Files           365      365              
  Lines         19384    19370      -14     
  Branches       2963     2961       -2     
============================================
- Hits          14162    14155       -7     
+ Misses         3793     3787       -6     
+ Partials       1429     1428       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukedegruchy lukedegruchy enabled auto-merge (squash) October 10, 2024 19:35
Copy link

sonarcloud bot commented Oct 10, 2024

@lukedegruchy lukedegruchy merged commit f236c13 into master Oct 10, 2024
8 checks passed
@lukedegruchy lukedegruchy deleted the ld-20241010-fix-measurement-period-evaluate-measure-delete-params branch October 10, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants