Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.🦀 #2

Closed
wants to merge 2 commits into from
Closed

.🦀 #2

wants to merge 2 commits into from

Conversation

Cuteistfox
Copy link

@Cuteistfox Cuteistfox commented May 30, 2023

What does this PR try to resolve?

Explain the motivation behind this change.
A clear overview along with an in-depth explanation are helpful.
replace .crab whith .🦀
Fixes #crablang/crab#53

@Cuteistfox Cuteistfox mentioned this pull request May 30, 2023
@Cuteistfox Cuteistfox marked this pull request as draft May 30, 2023 20:27
@Cuteistfox Cuteistfox marked this pull request as ready for review May 30, 2023 20:28
Copy link

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause the existing extension to break.
I think both .crab and .🦀 should be supported.

@Cuteistfox
Copy link
Author

Cuteistfox commented May 30, 2023

This will cause the existing extension to break. I think both .crab and .🦀 should be supported.
@Lissy93

@Lissy93 add it your self

@lleyton
Copy link

lleyton commented Jun 3, 2023

I'm fine with the crab emoji ext, but the default should probably be .crab. So yes, it's preferable to work with both.

@trvswgnr
Copy link
Contributor

trvswgnr commented Jun 5, 2023

it's much easier to replace the existing extension than it is to add support for an additional one, though i'm completely for it if someone wants to implement that 😊

closing this

@trvswgnr trvswgnr closed this Jun 5, 2023
@Cuteistfox
Copy link
Author

usen a if maybe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants