Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] make release should not put release in the shasum file. #611

Closed
praveenkumar opened this issue Sep 19, 2019 · 1 comment
Closed

[BUG] make release should not put release in the shasum file. #611

praveenkumar opened this issue Sep 19, 2019 · 1 comment
Labels
kind/bug Something isn't working

Comments

@praveenkumar
Copy link
Member

Currently we have the contents of sha256sum.txt, the hashes referencing items in a 'release' directory

49f30e59d1b66feb7e406ead155a2cd8b6808dc60488b7f147fc52a0fa641a51  release/crc-macos-amd64.tar.xz

It is hard to verify if do following, we should create it without including the directory.

$ sha256sum --check sha256sum.txt     
sha256sum: release/crc-macos-amd64.tar.xz: No such file or directory
release/crc-macos-amd64.tar.xz: FAILED open or read
sha256sum: release/crc-linux-amd64.tar.xz: No such file or directory
release/crc-linux-amd64.tar.xz: FAILED open or read
sha256sum: release/crc-windows-amd64.zip: No such file or directory
release/crc-windows-amd64.zip: FAILED open or read
sha256sum: release/crc_virtualbox_4.1.14.crcbundle: No such file or directory
release/crc_virtualbox_4.1.14.crcbundle: FAILED open or read
sha256sum: WARNING: 4 listed files could not be read
@praveenkumar praveenkumar added the kind/bug Something isn't working label Sep 19, 2019
praveenkumar added a commit that referenced this issue Sep 19, 2019
The hashes of sha256sum.txt are referencing items in a 'release' directory.
49f30e59d1b66feb7e406ead155a2cd8b6808dc60488b7f147fc52a0fa641a51  release/crc-macos-amd64.tar.xz

It makes hard to verify directly using the sha256sum.txt file on the content.

```
$ sha256sum --check sha256sum.txt
sha256sum: release/crc-macos-amd64.tar.xz: No such file or directory
release/crc-macos-amd64.tar.xz: FAILED open or read
sha256sum: release/crc-linux-amd64.tar.xz: No such file or directory
release/crc-linux-amd64.tar.xz: FAILED open or read
sha256sum: release/crc-windows-amd64.zip: No such file or directory
release/crc-windows-amd64.zip: FAILED open or read
sha256sum: release/crc_virtualbox_4.1.14.crcbundle: No such file or directory
release/crc_virtualbox_4.1.14.crcbundle: FAILED open or read
sha256sum: WARNING: 4 listed files could not be read
```
@praveenkumar
Copy link
Member Author

Fixed by #612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant