Issue #611 Don't include release dir to generated sha256 sum. #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hashes of sha256sum.txt are referencing items in a 'release' directory. 49f30e59d1b66feb7e406ead155a2cd8b6808dc60488b7f147fc52a0fa641a51 release/crc-macos-amd64.tar.xz It makes hard to verify directly using the sha256sum.txt file on the content. ``` $ sha256sum --check sha256sum.txt sha256sum: release/crc-macos-amd64.tar.xz: No such file or directory release/crc-macos-amd64.tar.xz: FAILED open or read sha256sum: release/crc-linux-amd64.tar.xz: No such file or directory release/crc-linux-amd64.tar.xz: FAILED open or read sha256sum: release/crc-windows-amd64.zip: No such file or directory release/crc-windows-amd64.zip: FAILED open or read sha256sum: release/crc_virtualbox_4.1.14.crcbundle: No such file or directory release/crc_virtualbox_4.1.14.crcbundle: FAILED open or read sha256sum: WARNING: 4 listed files could not be read ```
cfergeau
approved these changes
Sep 19, 2019
|
|
||
| @mkdir -p $(BUILD_DIR)/crc-windows-$(CRC_VERSION)-amd64 | ||
| @cp LICENSE $(DOCS_BUILD_DIR)/doc.pdf $(BUILD_DIR)/windows-amd64/crc.exe $(BUILD_DIR)/crc-windows-$(CRC_VERSION)-amd64 | ||
| cd $(BUILD_DIR) && zip -r $(CURDIR)/$(RELEASE_DIR)/crc-windows-amd64.zip crc-windows-$(CRC_VERSION)-amd64 | ||
| sha256sum $(RELEASE_DIR)/crc-windows-amd64.zip >> $(RELEASE_DIR)/sha256sum.txt | ||
|
|
||
| pushd $(RELEASE_DIR) && sha256sum * > sha256sum.txt && popd |
There was a problem hiding this comment.
do we want to be strict "just in case"? crc-*-amd64.* rather than just *?
There was a problem hiding this comment.
@cfergeau as of now there is no other files then our artifacts there, in future if it is then we might have to change that wildcard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hashes of sha256sum.txt are referencing items in a 'release' directory.
It makes hard to verify directly using the sha256sum.txt file on the content.